fix: throw error for invalid $refs missing the /
#102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darrenyong
changed the title
/
erunion
reviewed
Oct 4, 2023
erunion
reviewed
Oct 19, 2023
erunion
approved these changes
Oct 24, 2023
|
@erunion bumped the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
This fix seems a little... hard-coded? so I'm open to suggestions! It's literally just checking for the
#componentsstring anytime we try to dereference the file.Additionally, I'm using some optional chaining but ESLint doesn't like it. Is it okay to update the
parserOptions.ecmaVersionto2020?🧬 QA & Testing
I don't have a great way to test this but I've written a test for that specific case and all the other tests are passing.