refactor: throw error for invalid $refs #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erunion
reviewed
Oct 25, 2023
darrenyong
commented
Oct 25, 2023
| @@ -16,7 +16,7 @@ describe('Schema with invalid pointers', function () { | |||
| helper.shouldNotGetCalled(); | |||
| } catch (err) { | |||
| expect(err).to.be.an.instanceOf(InvalidPointerError); | |||
| expect(err.message).to.contain('Invalid $ref pointer "f". Pointers must begin with "#/"'); | |||
| expect(err.message).to.contain('Invalid $ref pointer "./invalid.json#f". Pointers must begin with "#/"'); | |||
There was a problem hiding this comment.
These types of refs are caught earlier now so it gives a more descriptive path on the invalid pointer.
|
just realized I never requested a re-review |
erunion
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
Follow up from #102
continueOnErrorsoption🧬 QA & Testing
Provide as much information as you can on how to test what you've done.