Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPdate base to use kern-6 and update pybdsf #676

Closed
wants to merge 3 commits into from
Closed

Conversation

Athanaseus
Copy link
Member

resolves #675

@ratt-priv-ci
Copy link
Collaborator

Can one of the admins verify this patch?

@o-smirnov
Copy link
Collaborator

I'll slap a DON'T MERGE label on it just for the moment, because switching everything over to KERN-6 seems like at least a minor (second-digit) release so maybe a bit more choreography is needed.

Should we do a 1.6.8 release with #678 #680 #682 merged, then release Caracal 1.0.4, then do Stimela 1.7.0 with this PR?

@KshitijT
Copy link
Collaborator

Should we do a 1.6.8 release with #678 #680 #682 merged, then release Caracal 1.0.4, then do Stimela 1.7.0 with this PR?

Please, let's do that, that way we can include @Mulan-94 's PR in Caracal 1.0.4 too.

@o-smirnov
Copy link
Collaborator

Which @Mulan-94 PR is this?

@KshitijT
Copy link
Collaborator

Which @Mulan-94 PR is this?

caracal-pipeline/caracal#1249. Relies on #680 .

@o-smirnov
Copy link
Collaborator

Ah yes, hence my concern here: #680 (comment)

@KshitijT
Copy link
Collaborator

Ah yes, hence my concern here: #680 (comment)

Yes, from what I see, @Mulan-94 has removed gaintype from ragavi invocations in CARACal, but it's a chicken-and-egg problem, as in we need new stimela to confirm CARACal runs fine with #680 ( and because I am too lazy to change stimela back-and-forth while testing multiple CARACal PRs).

@o-smirnov
Copy link
Collaborator

but it's a chicken-and-egg problem

Yers, which is why I made suggestions on #680 which should get around this, hopefully straight to the mammalian stage.

@o-smirnov o-smirnov mentioned this pull request Dec 11, 2020
@SpheMakh SpheMakh closed this Jan 26, 2022
@SpheMakh SpheMakh deleted the update_pybdsf branch October 30, 2023 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(Old version?) PyBDSM takes forever (or hangs) inside Stimela container
5 participants