Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated BDSM #693

Merged
merged 5 commits into from
Jan 27, 2021
Merged

updated BDSM #693

merged 5 commits into from
Jan 27, 2021

Conversation

o-smirnov
Copy link
Collaborator

No description provided.

@o-smirnov
Copy link
Collaborator Author

o-smirnov commented Dec 11, 2020 •
edited
Loading

This is a smaller update than #676 (as it doesn't update the base image), so can be done in a point release before #676 is merged.

If #676 goes in first, however, then this one is redundant.

@SpheMakh
Copy link
Collaborator

@o-smirnov can you please push the image to the online repo

quay.io/stimela/pybdsf:1.6.0

SpheMakh
SpheMakh requested changes Jan 26, 2021
View reviewed changes
Copy link
Collaborator

@SpheMakh SpheMakh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

base image is not online quay.io/stimela/pybdsf:1.6.0

@SpheMakh
Copy link
Collaborator

retest this please

@SpheMakh SpheMakh self-requested a review January 27, 2021 18:32
SpheMakh
SpheMakh approved these changes Jan 27, 2021
View reviewed changes
Copy link
Collaborator

@SpheMakh SpheMakh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@SpheMakh SpheMakh merged commit 8db7b47 into master Jan 27, 2021
@SpheMakh SpheMakh deleted the bsdf-update branch January 27, 2021 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SpheMakh SpheMakh SpheMakh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@o-smirnov @SpheMakh