netlink: cleanup interfaces upon removal #229
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when an interface was removed radvd did not release it's multicast membership leaking kernel resources leading to a potential out of memory failure of the `setsockopt([...], IPV6_ADD_MEMBERSHIP, [...])` call. Signed-off-by: Antoine Damhet <[email protected]>
|
@robbat2 did you have time to look ? as a side-note the code is running on multiple thousand of machines since late February without issue yet |
|
@reubenhwk: What do you think? |
|
I've look over the change and I agree that it is correct. It should be merged. |
reubenhwk
approved these changes
Sep 4, 2024
|
Why did the CI not run for the PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when an interface was removed radvd did not release it's multicast membership leaking kernel resources leading to a potential out of memory failure of the
setsockopt([...], IPV6_ADD_MEMBERSHIP, [...])call.Fixes #228