Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initializing the shard positions actor with the existing cluster state #4621

Merged
merged 2 commits into from
Feb 26, 2024
Merged

Initializing the shard positions actor with the existing cluster state #4621

merged 2 commits into from
Feb 26, 2024

Commits on Feb 26, 2024

  1. Ensuring we don't lose the first few position updates. 

    We had two problems here.
a) the ingester loads in an asynchronous fashion, as it needs to replay
the WAL entirely.
Subscribing to shard positions events is part of this initialization.
We could be missing all of the event received before the initialization (via chitchat).
b) we start the cluster first. Long after we in the initialization
process, we start the ShardPositionsService. We could possibly be
missing the keys that were shared in between.

Closes #4622
    @fulmicoton
    fulmicoton committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    7a72a6a View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Co-authored-by: Adrien "Code Monkey" Guillo <[email protected]>
    @fulmicoton @guilload
    fulmicoton and guilload committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    82fb6a2 View commit details
    Browse the repository at this point in the history