Initializing the shard positions actor with the existing cluster state #4621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fulmicoton
force-pushed
the
initialize-shard-positions
branch
2 times, most recently
from
84234d7
to
496ec2f
Compare
guilload
approved these changes
Feb 22, 2024
fulmicoton
force-pushed
the
initialize-shard-positions
branch
from
68f7de3
to
5721c7f
Compare
We had two problems here. a) the ingester loads in an asynchronous fashion, as it needs to replay the WAL entirely. Subscribing to shard positions events is part of this initialization. We could be missing all of the event received before the initialization (via chitchat). b) we start the cluster first. Long after we in the initialization process, we start the ShardPositionsService. We could possibly be missing the keys that were shared in between. Closes #4622
Co-authored-by: Adrien "Code Monkey" Guillo <[email protected]>
fulmicoton
force-pushed
the
initialize-shard-positions
branch
from
5721c7f
to
82fb6a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
on startup.
Chitchat is started before everything else, so we might be missing some positions if we just start listening for updates.