Close local shards and delete mrecordlog queues on ingester startup #3895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guilload
force-pushed
the
guilload/close-shards-delete-queues-on-startup
branch
3 times, most recently
from
6c315e7
to
66916b2
Compare
guilload
force-pushed
the
guilload/close-shards-delete-queues-on-startup
branch
from
66916b2
to
ff571c9
Compare
guilload
force-pushed
the
guilload/close-shards-delete-queues-on-startup
branch
from
ff571c9
to
1f9ddbb
Compare
Closed
guilload
force-pushed
the
guilload/close-shards-delete-queues-on-startup
branch
from
1f9ddbb
to
1de1432
Compare
fulmicoton
reviewed
Oct 6, 2023
guilload
force-pushed
the
guilload/close-shards-delete-queues-on-startup
branch
from
1de1432
to
64ea389
Compare
fulmicoton
reviewed
Oct 6, 2023
fulmicoton
reviewed
Oct 6, 2023
fulmicoton
reviewed
Oct 6, 2023
fulmicoton
reviewed
Oct 6, 2023
fulmicoton
reviewed
Oct 6, 2023
fulmicoton
approved these changes
Oct 6, 2023
guilload
force-pushed
the
guilload/close-shards-delete-queues-on-startup
branch
from
64ea389
to
0c7c884
Compare
guilload
force-pushed
the
guilload/close-shards-delete-queues-on-startup
branch
from
0c7c884
to
aa0fc9f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On startup, ingesters list their local mrecordlog queues and call the metastore to close the corresponding shards. If a shard no longer exists, its queue is deleted. Closed shards whose records have been indexed are eventually deleted by a GC task after a grace period has elapsed. The metastore notifies the control plane of the close and delete shards event.
How was this PR tested?