Router simplification #3737
Closed
Router simplification #3737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added comments, broke into methods. Most important non trivial changes. I simplified the router by changing the level of round robbin routing to shards (when several are available.) Instead of roundrobbin at the document scale, this round robbins over shards at each ingest requests. This simplifies the code in charge of dispatching ingest subrequests.
fulmicoton
force-pushed
the
router-simplification
branch
from
d59701f
to
7045eb6
Compare
guilload
force-pushed
the
guilload/ingest-v2/impl--router-and-ingester
branch
6 times, most recently
from
018ef45
to
2cb8b78
Compare
Base automatically changed from
guilload/ingest-v2/impl--router-and-ingester
to
main
August 14, 2023 16:19
|
I backported those changes in #3895. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.