Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate Control Plane codegen to quickwit-proto crate #3678

Merged
merged 1 commit into from
Jul 24, 2023
Merged

Migrate Control Plane codegen to quickwit-proto crate #3678

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions quickwit/Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion quickwit/quickwit-control-plane/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ quickwit-actors = { workspace = true }
quickwit-cluster = { workspace = true }
quickwit-common = { workspace = true }
quickwit-config = { workspace = true }
quickwit-grpc-clients = { workspace = true }
quickwit-indexing = { workspace = true }
quickwit-metastore = { workspace = true }
quickwit-proto = { workspace = true }
Expand All @@ -50,6 +49,7 @@ quickwit-cluster = { workspace = true, features = ["testsuite"] }
quickwit-common = { workspace = true, features = ["testsuite"] }
quickwit-config = { workspace = true, features = ["testsuite"] }
quickwit-metastore = { workspace = true, features = ["testsuite"] }
quickwit-proto = { workspace = true, features = ["testsuite"] }
quickwit-storage = { workspace = true, features = ["testsuite"] }

[build-dependencies]
Expand Down
31 changes: 0 additions & 31 deletions quickwit/quickwit-control-plane/build.rs
View file
Open in desktop

This file was deleted.

4 changes: 2 additions & 2 deletions quickwit/quickwit-control-plane/src/control_plane.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,10 @@
use anyhow::Context;
use async_trait::async_trait;
use quickwit_actors::{Actor, ActorContext, ActorExitStatus, Handler, Mailbox};
use quickwit_proto::control_plane::{NotifyIndexChangeRequest, NotifyIndexChangeResponse};
use tracing::debug;

use crate::scheduler::IndexingScheduler;
use crate::{NotifyIndexChangeRequest, NotifyIndexChangeResponse};

#[derive(Debug)]
pub struct ControlPlane {
Expand Down Expand Up @@ -51,7 +51,7 @@ impl ControlPlane {

#[async_trait]
impl Handler<NotifyIndexChangeRequest> for ControlPlane {
type Reply = crate::Result<NotifyIndexChangeResponse>;
type Reply = quickwit_proto::control_plane::Result<NotifyIndexChangeResponse>;

async fn handle(
&mut self,
Expand Down
140 changes: 0 additions & 140 deletions quickwit/quickwit-control-plane/src/grpc_adapter.rs
View file
Open in desktop

This file was deleted.

4 changes: 2 additions & 2 deletions quickwit/quickwit-control-plane/src/indexing_plan.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,8 +324,8 @@ mod tests {
FileSourceParams, KafkaSourceParams, SourceConfig, SourceInputFormat, SourceParams,
CLI_INGEST_SOURCE_ID, INGEST_API_SOURCE_ID,
};
use quickwit_proto::indexing::IndexingTask;
use quickwit_proto::{IndexUid, IndexingServiceClient};
use quickwit_proto::indexing::{IndexingServiceClient, IndexingTask};
use quickwit_proto::IndexUid;
use rand::seq::SliceRandom;
use serde_json::json;
use tonic::transport::Endpoint;
Expand Down
Loading
Loading