Migrate Control Plane codegen to quickwit-proto crate
#3678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guilload
commented
Jul 24, 2023
| pub mod indexing; | ||
| #[path = "quickwit/quickwit.metastore.rs"] | ||
| #[path = "codegen/quickwit/quickwit.metastore.rs"] |
There was a problem hiding this comment.
At this point, we want some code formatting in quickwit_proto, so I moved all the generated files to a codegen folder.
imotov
approved these changes
Jul 24, 2023
There was a problem hiding this comment.
Really nice clean-up!
It looks like we could now move the service_client_pool from grpc-clients into search crate and get rid of grpc-clients crate. This crate confused me earlier because I didn't realize it is part of the legacy structure. So, maybe we should also deprecate service_client_pool for good measure.
guilload
force-pushed
the
guilload/migrate-control-plane-proto-to-quickwit-proto
branch
from
8c2e4cc
to
65c85d5
Compare
|
Yes. We might be able to get rid of |
guilload
deleted the
guilload/migrate-control-plane-proto-to-quickwit-proto
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I'm also trying to align naming and packaging conventions between services.
How was this PR tested?
make test-all