Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested layout #570

Merged
merged 11 commits into from
Apr 13, 2021
Merged

Nested layout #570

merged 11 commits into from
Apr 13, 2021

Conversation

T-Wizard
Copy link
Collaborator

Add Support for Components in Components (#181)

A simpler more limited alternative to master...nilzona:compose-api

Checklist

@nilzona
Copy link
Collaborator

nilzona commented Mar 23, 2021

@T-Wizard This looks promising. Do you think you can add an example picasso configuration to try it out?

@T-Wizard
Copy link
Collaborator Author

@nilzona: added two examples in the studio

@T-Wizard T-Wizard force-pushed the nested-layout branch 2 times, most recently from 441902b to 4c0d694 Compare March 23, 2021 13:14
Comment on lines 56 to 34
return {
index: i,
key: c.settings.key,
dockConfig,
resize: c.instance.resize,
preferredSize(opts) {
return dockConfig.computePreferredSize({ ...opts, children: wrapChildren(c.children) });
},
};
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any suggestion on what information is needed by different types of layout functions?

@T-Wizard T-Wizard marked this pull request as ready for review March 29, 2021 13:36
@T-Wizard T-Wizard changed the title [Prototype] Nested layout Nested layout Mar 30, 2021
@@ -1973,6 +2017,25 @@
}
}
},
"ContainerComponent": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You forgot to build the spec

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done
(many changes in the spec, probably not any rebuild since the last rebase from master)

@T-Wizard T-Wizard merged commit 03fe928 into qlik-oss:master Apr 13, 2021
@T-Wizard T-Wizard deleted the nested-layout branch April 13, 2021 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants