Nested layout #570
Merged
Nested layout #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@T-Wizard This looks promising. Do you think you can add an example picasso configuration to try it out? |
|
@nilzona: added two examples in the studio |
T-Wizard
force-pushed
the
nested-layout
branch
2 times, most recently
from
441902b
to
4c0d694
Compare
T-Wizard
commented
Mar 23, 2021
Comment on lines
56
to
34
| return { | ||
| index: i, | ||
| key: c.settings.key, | ||
| dockConfig, | ||
| resize: c.instance.resize, | ||
| preferredSize(opts) { | ||
| return dockConfig.computePreferredSize({ ...opts, children: wrapChildren(c.children) }); | ||
| }, | ||
| }; |
There was a problem hiding this comment.
any suggestion on what information is needed by different types of layout functions?
T-Wizard
commented
Mar 25, 2021
veinfors
reviewed
Apr 12, 2021
veinfors
approved these changes
Apr 12, 2021
cbt1
reviewed
Apr 13, 2021
packages/picasso.js/src/core/chart-components/container/container.js
Outdated
Show resolved
Hide resolved
cbt1
reviewed
Apr 13, 2021
docs/scriptappy.json
Outdated
| @@ -1973,6 +2017,25 @@ | |||
| } | |||
| } | |||
| }, | |||
| "ContainerComponent": { | |||
There was a problem hiding this comment.
You forgot to build the spec
There was a problem hiding this comment.
done
(many changes in the spec, probably not any rebuild since the last rebase from master)
cbt1
approved these changes
Apr 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Support for Components in Components (#181)
A simpler more limited alternative to master...nilzona:compose-api
Checklist