Skip to content

Commit

Permalink
docs: mark as experimental
Browse files Browse the repository at this point in the history
  • Loading branch information
T-Wizard committed Apr 12, 2021
1 parent cbd1d5c commit 22994c0
Show file tree
Hide file tree
Showing 3 changed files with 21 additions and 3 deletions.
6 changes: 4 additions & 2 deletions docs/scriptappy.json
Original file line number Diff line number Diff line change
Expand Up @@ -904,7 +904,8 @@
"kind": "array",
"items": {
"type": "#/definitions/ComponentSettings"
}
},
"stability": "experimental"
},
"strategy": {
"description": "Layout strategy used for child components.",
Expand All @@ -918,7 +919,8 @@
"type": "#/definitions/CustomLayoutFunction"
}
],
"type": "any"
"type": "any",
"stability": "experimental"
}
}
},
Expand Down
16 changes: 16 additions & 0 deletions packages/picasso.js/src/core/chart/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,22 @@ import componentCollectionFn from './component-collection';
* @property {DockLayoutSettings|CustomLayoutFunction} [strategy] Layout strategy used for child components.
*/

// mark strategy as experimental
/**
* @type {DockLayoutSettings|CustomLayoutFunction}
* @name strategy
* @memberof ComponentSettings
* @experimental
*/

// mark components as experimental
/**
* @type {ComponentSettings[]}
* @name components
* @memberof ComponentSettings
* @experimental
*/

function addComponentDelta(shape, containerBounds, componentBounds) {
const dx = containerBounds.left - componentBounds.left;
const dy = containerBounds.top - componentBounds.top;
Expand Down
2 changes: 1 addition & 1 deletion packages/picasso.js/src/core/layout/dock/docker.js
Original file line number Diff line number Diff line change
Expand Up @@ -406,7 +406,7 @@ function dockLayout(initialSettings) {
throw new Error('Invalid rect');
}
if (!components.length) {
return { visible: [], hidden: [], order: [] };
return { visible: [], hidden: [], ordered: [] };
}

const { logicalContainerRect, containerRect } = resolveContainerRects(rect, settings);
Expand Down

0 comments on commit 22994c0

Please sign in to comment.