Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: prepare compose API #354

Merged
merged 3 commits into from
Apr 4, 2019
Merged

Conversation

nilzona
Copy link
Collaborator

@nilzona nilzona commented Apr 3, 2019

This PR is about preparing for the compose api described in #181 the dock layout settings in component settings has now been deprecated and they should be moved into a layout property.
A component definition that previously had:

{
   type: 'axis',
   dock: 'right',
   displayOrder: 3
}

Should instead be:

{
   type: 'axis',
   layout: {
      dock: 'right',
      displayOrder: 3
   }
}

Also dock layout engine has been moved and changed somewhat for preparing the compose api.

Checklist

@nilzona nilzona requested a review from miralemd April 3, 2019 10:30
@miralemd miralemd changed the title Prepare compose api refactor: prepare compose api Apr 4, 2019
@miralemd miralemd changed the title refactor: prepare compose api refactor: prepare compose API Apr 4, 2019
@nilzona nilzona merged commit 2de81ca into qlik-oss:master Apr 4, 2019
@nilzona nilzona deleted the prepare-layout-api branch April 4, 2019 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants