Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: revert userSettings #370

Merged
merged 1 commit into from
Apr 9, 2019
Merged

refactor: revert userSettings #370

merged 1 commit into from
Apr 9, 2019

Conversation

nilzona
Copy link
Collaborator

@nilzona nilzona commented Apr 9, 2019

in #354 we introduced that component definition can access the settings provided by the user with this.userSettings. This reverts the change

Checklist

@nilzona nilzona requested a review from miralemd April 9, 2019 07:36
@nilzona nilzona merged commit 1c11ddb into qlik-oss:master Apr 9, 2019
@nilzona nilzona deleted the revUserSettings branch April 9, 2019 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miralemd miralemd miralemd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nilzona @miralemd