Original hill function definition #925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wd60622 What do you think about this proposal? I think it is very reasonable. |
juanitorduz
force-pushed
the
original_hill_function_def
branch
from
798e6bd
to
782584d
Compare
juanitorduz
force-pushed
the
original_hill_function_def
branch
from
818eb54
to
69f80be
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #925 +/- ##
==========================================
+ Coverage 94.49% 94.51% +0.01%
==========================================
Files 34 34
Lines 3381 3388 +7
==========================================
+ Hits 3195 3202 +7
Misses 186 186 ☔ View full report in Codecov by Sentry. |
wd60622
approved these changes
Aug 12, 2024
juanitorduz
force-pushed
the
original_hill_function_def
branch
from
73988af
to
736f785
Compare
Thanks! Good catch! Fixed! |
radiokosmos
pushed a commit
to radiokosmos/pymc-marketing
that referenced
this pull request
Sep 3, 2024
twiecki
pushed a commit
that referenced
this pull request
Sep 10, 2024
twiecki
pushed a commit
that referenced
this pull request
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #917
In #917 (comment) it is suggested to use Equation 5 from https://static.googleusercontent.com/media/research.google.com/en//pubs/archive/46001.pdf to have the original definition. I renamed the previous one as people might find it useful.
📚 Documentation preview 📚: https://pymc-marketing--925.org.readthedocs.build/en/925/