-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Original hill function definition #925
Conversation
@wd60622 What do you think about this proposal? I think it is very reasonable. |
798e6bd
to
782584d
Compare
818eb54
to
69f80be
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #925 +/- ##
==========================================
+ Coverage 94.49% 94.51% +0.01%
==========================================
Files 34 34
Lines 3381 3388 +7
==========================================
+ Hits 3195 3202 +7
Misses 186 186 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just question about the spaces. Don't think that causes any issues with docs though
73988af
to
736f785
Compare
Thanks! Good catch! Fixed! |
Closes #917
In #917 (comment) it is suggested to use Equation 5 from https://static.googleusercontent.com/media/research.google.com/en//pubs/archive/46001.pdf to have the original definition. I renamed the previous one as people might find it useful.
📚 Documentation preview 📚: https://pymc-marketing--925.org.readthedocs.build/en/925/