-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
does hill_sat go through (0, 0) #917
Comments
but does this fix mean that sigma is still the aymptote for all positive values of lambda and beta? |
Actually, it's going to be sigma minus the offset. Let me reopen this issue and see if we can bring back the original parametrization. Maybe @dirknbr you wanna give it a go? :) |
why not use equation 4 of https://static.googleusercontent.com/media/research.google.com/en//pubs/archive/46001.pdf |
Ok! Seems the way to go. I am unsure about the current parameterization via exponentials. |
Ok! Sterted a PR #925 |
We added the original implementation of the paper (with the corresponding reference) |
Is it possible that your hill_saturation function doesn't pass through (0, 0), which would be necessary since we assume 0 sales if a single channel is 0
The text was updated successfully, but these errors were encountered: