Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make hill pass through the origin #920

Merged
merged 7 commits into from
Aug 12, 2024
Merged

make hill pass through the origin #920

merged 7 commits into from
Aug 12, 2024

Conversation

juanitorduz
Copy link
Collaborator

@juanitorduz juanitorduz commented Aug 9, 2024 •
edited by github-actions bot
Loading

Closes #917 by adding a constant

📚 Documentation preview 📚: https://pymc-marketing--920.org.readthedocs.build/en/920/

@juanitorduz juanitorduz marked this pull request as draft August 9, 2024 22:08
@juanitorduz juanitorduz self-assigned this Aug 9, 2024
@juanitorduz juanitorduz added enhancement New feature or request MMM labels Aug 9, 2024
@codecov Codecov
Copy link

codecov bot commented Aug 9, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.58%. Comparing base (b070375) to head (7dedf4a).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #920   +/-   ##
=======================================
  Coverage   94.58%   94.58%           
=======================================
  Files          33       33           
  Lines        3378     3378           
=======================================
  Hits         3195     3195           
  Misses        183      183

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@juanitorduz juanitorduz marked this pull request as ready for review August 9, 2024 22:34
wd60622
wd60622 reviewed Aug 10, 2024
View reviewed changes
Copy link
Contributor

@wd60622 wd60622 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the SaturationTransformation priors change with this change?

pymc_marketing/mmm/transformers.py Show resolved Hide resolved
@wd60622
Copy link
Contributor

wd60622 commented Aug 10, 2024

The plot of the current priors as reference: https://pymc-marketing--920.org.readthedocs.build/en/920/api/generated/pymc_marketing.mmm.components.saturation.HillSaturation.html

@juanitorduz
Copy link
Collaborator Author

The plot of the current priors as reference: https://pymc-marketing--920.org.readthedocs.build/en/920/api/generated/pymc_marketing.mmm.components.saturation.HillSaturation.html

Looks good as they all pass through the origin as expected. I constrained the priors a bit.

@juanitorduz juanitorduz mentioned this pull request Aug 11, 2024
Closed
@juanitorduz juanitorduz merged commit 285f704 into main Aug 12, 2024
13 checks passed
@wd60622 wd60622 deleted the hill_constant branch August 12, 2024 07:37
@wd60622 wd60622 added this to the 0.9.0 milestone Aug 14, 2024
radiokosmos pushed a commit to radiokosmos/pymc-marketing that referenced this pull request Sep 3, 2024
@juanitorduz @radiokosmos
make hill pass through the origin (pymc-labs#920)
50a537d
twiecki pushed a commit that referenced this pull request Sep 10, 2024
@juanitorduz @twiecki
make hill pass through the origin (#920)
dfb2a90
twiecki pushed a commit that referenced this pull request Sep 10, 2024
@juanitorduz @twiecki
make hill pass through the origin (#920)
6cd888e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wd60622 wd60622 wd60622 approved these changes

@cetagostini cetagostini Awaiting requested review from cetagostini

Assignees

@juanitorduz juanitorduz

Labels
enhancement New feature or request MMM
Projects
None yet
Milestone
0.9.0
Development

Successfully merging this pull request may close these issues.

does hill_sat go through (0, 0)
2 participants
@juanitorduz @wd60622