-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make hill pass through the origin #920
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #920 +/- ##
=======================================
Coverage 94.58% 94.58%
=======================================
Files 33 33
Lines 3378 3378
=======================================
Hits 3195 3195
Misses 183 183 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the SaturationTransformation priors change with this change?
The plot of the current priors as reference: https://pymc-marketing--920.org.readthedocs.build/en/920/api/generated/pymc_marketing.mmm.components.saturation.HillSaturation.html |
Looks good as they all pass through the origin as expected. I constrained the priors a bit. |
Closes #917 by adding a constant
📚 Documentation preview 📚: https://pymc-marketing--920.org.readthedocs.build/en/920/