WIP: Add expected cumulative transaction func #692

wd60622 · 2024-05-19T13:40:51Z

Description

This adapts this lifetimes function

Hi @ColtAllen
Finally getting to this edit.

What is the equivalent method for this lifetimes one? That'd be expected_num_purchases, right?

Related Issue

Closes #
Related to Adapt Evaluation Plots from lifetimes #326

Checklist

Checked that the pre-commit linting/style checks pass
Included tests that prove the fix is effective or that the new feature works
Added necessary documentation (docstrings and/or example notebooks)
If you are a pro: each commit corresponds to a relevant logical change

Modules affected

MMM
CLV

Type of change

📚 Documentation preview 📚: https://pymc-marketing--692.org.readthedocs.build/en/692/

* add scaling into lift test method * test scaling methods * test change of MMM likelihood * link up beta_channel parameters * change name to sigma * reorganize and edit * closes #406 * address the feedback in docstrings * add more to docstring * format the docstring * be verbose for future devs * be explicit for the column max values * incorporate the feedback * hide cells and add to intro * add conclusion * switch to header 2 * run notebook through * move the types together * separate model estimated from empirical * fix typos

* drop python 3.9 * try python 3.12 * undo try python 3.12

* improve nb * rm warnings and add link to lifetimes quickstart * address comments * feedback part 3 * remove warnings manually

* add more info to the notebook * hide plots code * fix plot y labels * fix plot outputs and remove model build * improve final note probability plots * address comments * use quickstart dataset * feedback part 3 * remowe warnings manually * feedback part 4

* improve mmm docs init * add more code examples to docstrings * minor improvemeents * typo * better phrasing * add thomas suggestion

* move fixtures to conftest * docstrings and moved set_model_fit to conftest * fixed pandas quickstart warnings * revert to MockModel and add ParetoNBD support * quickstart edit for issue 609 * notebook edit

remove ruff E501 ignore

updates: - [github.com/astral-sh/ruff-pre-commit: v0.3.5 → v0.3.7](astral-sh/ruff-pre-commit@v0.3.5...v0.3.7) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Juan Orduz <[email protected]>

* fix potential bugs * minor improvements * remove rule for nb * fix test * improve tests syntax * use stacklevel 2 for warnings * use stacklevel 1 for warnings as they are used in public methods * ignore B904 * undo change * ricardos feedback * use fit_posterior * Update pymc_marketing/clv/models/gamma_gamma.py Co-authored-by: Ricardo Vieira <[email protected]> * last fix XD --------- Co-authored-by: Ricardo Vieira <[email protected]>

* notebook opening and imports * model definition markdown * Data Load Notebook section * WIP model fitting section * added notebook to docs directory * notebook edits and graph code * ppc section and nb cleanup * demz sampling and WIP plotting * WIP predictive plots * WIP heatmap plots * predictive plots * WIP covariates and nbqa-ruff edits * covariate section * plot additions * fig sizes * remove model file

…book (#651) * add spaces, increase indentation, and fix number order * explicit with 6

* Creating plot waterfall Co-Authored-By: Carlos Trujillo <[email protected]> * requested changes * pre-commit --------- Co-authored-by: Carlos Trujillo <[email protected]>

Databricks should have a lower-case b.

updates: - [github.com/astral-sh/ruff-pre-commit: v0.4.1 → v0.4.2](astral-sh/ruff-pre-commit@v0.4.1...v0.4.2) - [github.com/pre-commit/mirrors-mypy: v1.9.0 → v1.10.0](pre-commit/mirrors-mypy@v1.9.0...v1.10.0) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* support for negative values and dates (if used) * fix terrible spelling * test dates in coords * cover numpy objects * consolidate the tests

* use get instead of assign to default to sampler_config if exists * default to what is given * write tests based on the issue * have defaults while not overriding

* Enforce check_parameters in geometric_adstock * Remove check_parameters on l_max. Revert to original test * Add test_geometric_adstock_bad_alpha * use ge, le instead of gt,lt * Update tests/mmm/test_transformers.py Co-authored-by: Will Dean <[email protected]> * Simplify test parameters * Update tests/mmm/test_transformers.py Co-authored-by: Will Dean <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: Will Dean <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* change repo and python file change to kick off * comment to check for failure * using the repo * delete to trigger * the previous trigger * push up again * check for the owner being pymc-labs * remove unused * only run after merge to main

* deprecations and moving files * Update UML Diagrams * change the imports in notebooks * push up the code / test changes. need to run * remove _get_\w*_function tests * rerun the tvp notebook * remove stale test * move away from string initialization * change the tvp media example

* allow register and use custom transform * add to the example block

updates: - [github.com/astral-sh/ruff-pre-commit: v0.6.1 → v0.6.2](astral-sh/ruff-pre-commit@v0.6.1...v0.6.2) - [github.com/pre-commit/mirrors-mypy: v1.11.1 → v1.11.2](pre-commit/mirrors-mypy@v1.11.1...v1.11.2) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

Co-authored-by: Will Dean <[email protected]> Co-authored-by: Juan Orduz <[email protected]>

* add table * sync index * empty * improvements

* nb init * add param stability * crps init * add crps to package * make mypy happy * clean * relax req * update path * add crps test * first iteration * improvements * improve tests * improve tests * improve references * feedback 1 * add examples

…sets of channels (#968)

…ocs (#992) * Changed pt=pt to pt_lib = None to avoid showing full module path in docs * Changed pt to pt_lib inside calculate_lift_measurements_from_curve

* push up some linear-trend work I had * image for the documentation * start the slopes at t=0 * additional checks at init * import at mmm module * update the image * Move to reference section * Move coords to single line * Add hierarchical trend example * add image for the example * migrate to pydantic * update images after seed * Correct the latex * fix check from tests

updates: - [github.com/astral-sh/ruff-pre-commit: v0.6.2 → v0.6.3](astral-sh/ruff-pre-commit@v0.6.2...v0.6.3) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

Co-authored-by: Juan Orduz <[email protected]>

ColtAllen · 2024-09-03T14:42:05Z

tests/clv/test_utils.py

@@ -948,6 +948,7 @@ def test_expected_cumulative_transactions_date_index(fitted_bg, cdnow_trans):
    observation_period_end = "19970930"
    time_scaler = 1

+    # Still tracking this function down


The equivalent pymc-marketing function is rfm_summary.

Thanks.

I'm getting a bit confused now because the result doesn't have dates in it, right? Feel like this function is doing a lot

There is a set_index_date argument. If True then the returned dataframe will have a datetime index. By default it's False and the index can be interpreted as the number of time periods since the origin, but I'm not entirely sure how useful of a feature this is.

wd60622 and others added 30 commits April 2, 2024 15:07

Drop python 3.9 support (#615)

8590b45

* drop python 3.9 * try python 3.12 * undo try python 3.12

add lift tests check

27a55d5

Add more content to the Gamma-Gamma Notebook (#573)

f3ec2cf

* improve nb * rm warnings and add link to lifetimes quickstart * address comments * feedback part 3 * remove warnings manually

Improve MMM Docs (#612)

da9f025

* improve mmm docs init * add more code examples to docstrings * minor improvemeents * typo * better phrasing * add thomas suggestion

Fix clv plotting bugs and edits to Quickstart (#601)

38b55a2

* move fixtures to conftest * docstrings and moved set_model_fit to conftest * fixed pandas quickstart warnings * revert to MockModel and add ParetoNBD support * quickstart edit for issue 609 * notebook edit

[pre-commit.ci] pre-commit autoupdate (#616)

ffef5a6

improve coords matching (#623)

a151330

python 3.12 attempt (#618)

6f33cef

closes #520 (#621) dataset -> data

c40c8b8

mmm example notebook small fixes (#626)

ff937f4

Remove ruff E501 ignore (#619)

e2dba27

remove ruff E501 ignore

Update pypi.yml (dash change) (#633)

b777eb5

UP rule ruff (#635)

2be2f63

Add ruff RUF rules (#636)

582d2ed

Update version.txt (#640)

78964f0

[pre-commit.ci] pre-commit autoupdate (#642)

18d926c

Fix build badge (#645)

ce41f5f

Add downloads stats to README

818781a

add spaces, increase indentation, and fix number order to Pareto note…

7034e28

…book (#651) * add spaces, increase indentation, and fix number order * explicit with 6

Add link to new Pareto notebook (#649)

d531d0c

Plot Waterfall Components Decomposition (#631)

1c186f0

* Creating plot waterfall Co-Authored-By: Carlos Trujillo <[email protected]> * requested changes * pre-commit --------- Co-authored-by: Carlos Trujillo <[email protected]>

Update resources.md (#652)

b36b0ac

Databricks should have a lower-case b.

fix ylabel (#654)

ae6ae1d

Lift test fixes (#656)

a89bd93

* support for negative values and dates (if used) * fix terrible spelling * test dates in coords * cover numpy objects * consolidate the tests

wd60622 and others added 21 commits August 22, 2024 19:56

Ensure fit reproducibility (#963)

1536dad

* use get instead of assign to default to sampler_config if exists * default to what is given * write tests based on the issue * have defaults while not overriding

scaling should be done before hdi computation (#970)

bb8d063

Register and allow custom transform for Prior class (#972)

0c90ba8

* allow register and use custom transform * add to the example block

Update pypi.yml (#975)

cc89b95

Added deprecation warning for method keyword (#974)

28b75c3

Co-authored-by: Will Dean <[email protected]> Co-authored-by: Juan Orduz <[email protected]>

Improve and sync the README and landing page. (#978)

6c46d59

* add table * sync index * empty * improvements

fix the wrong trigger (#983)

3048a74

Media transformation class and different transformations based on sub…

f2318ae

…sets of channels (#968)

Changed pt=pt to pt_lib = None to avoid showing full module path in d…

2e2907a

…ocs (#992) * Changed pt=pt to pt_lib = None to avoid showing full module path in docs * Changed pt to pt_lib inside calculate_lift_measurements_from_curve

[pre-commit.ci] pre-commit autoupdate (#994)

292bd7c

updates: - [github.com/astral-sh/ruff-pre-commit: v0.6.2 → v0.6.3](astral-sh/ruff-pre-commit@v0.6.2...v0.6.3) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

always push to main (#993)

4e2d722

Co-authored-by: Juan Orduz <[email protected]>

Merge branch 'main' into add-expected-cumulative-transaction-func

f54712a

change to time_scaler and new method name

379e57a

migrate existing tests from lifetimes

805146e

comment for progress status

141db06

ColtAllen reviewed Sep 3, 2024

View reviewed changes

invert logic

87c4b89

ulfaslak force-pushed the main branch 4 times, most recently from f9a38fd to 818ba39 Compare September 8, 2024 12:38

twiecki force-pushed the main branch from 35dc7f1 to 9f9c67f Compare September 10, 2024 15:25

wd60622 closed this Sep 14, 2024

wd60622 deleted the add-expected-cumulative-transaction-func branch September 14, 2024 09:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WIP: Add expected cumulative transaction func #692

WIP: Add expected cumulative transaction func #692

wd60622 commented May 19, 2024 •

edited

Loading

ColtAllen Sep 3, 2024

wd60622 Sep 4, 2024

ColtAllen Sep 5, 2024

WIP: Add expected cumulative transaction func #692

WIP: Add expected cumulative transaction func #692

Conversation

wd60622 commented May 19, 2024 • edited Loading

Description

Related Issue

Checklist

Modules affected

Type of change

ColtAllen Sep 3, 2024

Choose a reason for hiding this comment

wd60622 Sep 4, 2024

Choose a reason for hiding this comment

ColtAllen Sep 5, 2024

Choose a reason for hiding this comment

wd60622 commented May 19, 2024 •

edited

Loading