Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support numpy arrays in model_config #351

Merged

Conversation

michaelraczycki
Copy link
Contributor

@michaelraczycki michaelraczycki commented Aug 9, 2023

This PR addresses issue mentioned in #348. As on the development stage only certain priors were shown to use arrays, I didn't include it at the time, but seeing users trying to include them I've added more thorough algorithm to scan all the fields of model config and ensure their JSON serialization.

Closes #333
Closes #348


📚 Documentation preview 📚: https://pymc-marketing--351.org.readthedocs.build/en/351/

@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Merging #351 (8a6b81b) into main (8c38233) will decrease coverage by 2.23%.
Report is 3 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #351      +/-   ##
==========================================
- Coverage   95.85%   93.62%   -2.23%     
==========================================
  Files          19       20       +1     
  Lines        1447     1664     +217     
==========================================
+ Hits         1387     1558     +171     
- Misses         60      106      +46     
Files Changed Coverage Δ
pymc_marketing/mmm/delayed_saturated_mmm.py 100.00% <100.00%> (+0.53%) ⬆️

... and 6 files with indirect coverage changes

@ricardoV94 ricardoV94 added the enhancement New feature or request label Aug 18, 2023
@ricardoV94 ricardoV94 changed the title model_config priors support np.arrays Support np.ndarray in model_config Aug 18, 2023
@ricardoV94 ricardoV94 merged commit 953fea2 into pymc-labs:main Aug 18, 2023
11 checks passed
@ricardoV94 ricardoV94 changed the title Support np.ndarray in model_config Support numpy arrays in model_config Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DelayedSaturatedMMM.load() error matching model ID Can't load MMM with vector parameter prior
2 participants