-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't load MMM with vector parameter prior #333
Comments
It's something that comes from json encoding. It's impossible to determine if json list was encoded from np.array, or from list. Because of that load automatically creates np.array in place of each json list found in the model_config. I see that I need to create full documentation of the model builder module and it's retirements/limitations. |
What about sanitizing the config (after making a copy) so the user doesn't have to worry about that? In this case convert lists to numpy arrays. |
that can also be done, although I think I'd suggest to first release the intro notebook, and then start patching up those topics as the jsonification looks like a bottomless pit, probably every once in a while we'll get a bug report about that. |
I'll open another issue in pymc-experimental to keep track of that |
I've opened a PR that now will convert any lists or arrays found inside the model_config into np.array format before assigning model_config inside the DelayedSaturatedMMM, probably merging #351 should solve your problem |
Grabbing the current example in #324 , and changing the beta prior to:
I then fail to load the model after saving with:
The error doesn't happen if I use a scalar
sigma
.CC @michaelraczycki
The text was updated successfully, but these errors were encountered: