Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test for expected exception instead of xfail #1114

Merged
merged 11 commits into from
Oct 24, 2024
Merged

Test for expected exception instead of xfail #1114

Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
c5becdc
Use of pytest.raises #1109
nhan295 Oct 24, 2024
4ab417b
Merge branch 'main' into iamnhan
wd60622 Oct 24, 2024
7ea372e
Merge branch 'main' into iamnhan
wd60622 Oct 24, 2024
ec2ee18
Implemented request change #1114
nhan295 Oct 24, 2024
aaaff63
Merge branch 'iamnhan' of https://github.com/nhan295/pymc-marketing i…
nhan295 Oct 24, 2024
ae9ad28
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Oct 24, 2024
49b3fb6
Fix request change #1114
nhan295 Oct 24, 2024
4fc052c
Fix change request #1114
nhan295 Oct 24, 2024
739d420
Fix request change #1114
nhan295 Oct 24, 2024
7a38f3b
Merge branch 'main' into iamnhan
wd60622 Oct 24, 2024
5af8da4
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Oct 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions tests/test_model_builder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,12 +257,15 @@ def test_fit_no_t(toy_X):
assert "posterior" in model_builder.idata.groups()


@pytest.mark.xfail
def test_fit_dup_Y(toy_X):
# create redundant target column in X
def test_fit_dup_Y(toy_X, toy_y):
toy_X = pd.concat((toy_X, toy_y), axis=1)
model_builder = ModelBuilderTest()
model_builder.fit(X=toy_X, chains=1, draws=100, tune=100)

with pytest.raises(
ValueError,
match="X includes a column named 'output', which conflicts with the target variable.",
):
model_builder.fit(X=toy_X, chains=1, draws=100, tune=100)


@pytest.mark.skipif(
Expand Down
Loading