Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test for expected exception instead of xfail #1114

Merged
merged 11 commits into from
Oct 24, 2024

Conversation

nhan295
Copy link
Contributor

@nhan295 nhan295 commented Oct 24, 2024

Description

Related Issue

Checklist

Modules affected

  • MMM
  • CLV

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

📚 Documentation preview 📚: https://pymc-marketing--1114.org.readthedocs.build/en/1114/

@github-actions github-actions bot added the tests label Oct 24, 2024
@wd60622 wd60622 changed the title Closes #1109 Test for expected exception instead of xfail Oct 24, 2024
tests/test_model_builder.py Outdated Show resolved Hide resolved
@juanitorduz
Copy link
Collaborator

Thank you @nhan295 ! I think is almost there.

@wd60622
Copy link
Contributor

wd60622 commented Oct 24, 2024

pre-commit.ci autofix

tests/test_model_builder.py Outdated Show resolved Hide resolved
@wd60622
Copy link
Contributor

wd60622 commented Oct 24, 2024

pre-commit.ci autofix

@wd60622
Copy link
Contributor

wd60622 commented Oct 24, 2024

FYI @nhan295 run pre-commit install locally to get rid the pre-commit failures

@juanitorduz
Copy link
Collaborator

Thank you @nhan295 !

@juanitorduz juanitorduz merged commit 9b22791 into pymc-labs:main Oct 24, 2024
13 checks passed
@nhan295 nhan295 deleted the iamnhan branch October 24, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test for expected exception
3 participants