Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix duplicate workflow step ids #9934

Merged
merged 2 commits into from
Sep 19, 2024
Merged

Fix duplicate workflow step ids #9934

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
538ba0e
Fix duplicate workflow step ids
jacobtylerwalls Sep 18, 2024
500a9e5
Just remove extraneous step ids
jacobtylerwalls Sep 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/primer_run_main.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ jobs:

# Create a re-usable virtual environment
- name: Restore Python virtual environment cache
id: cache-venv
id: cache-venv-restore
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should conditionals with the old ID be updated too?

if: steps.cache-venv.outputs.cache-hit != 'true'

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Realized I can probably just delete the new id's I accidentally introduced.

uses: actions/cache/[email protected]
with:
path: venv
Expand All @@ -63,7 +63,7 @@ jobs:
# Save cached Python environment (explicit because cancel-in-progress: true)
- name: Save Python virtual environment to cache
if: steps.cache-venv.outputs.cache-hit != 'true'
id: cache-venv
id: cache-venv-save
uses: actions/cache/[email protected]
with:
path: venv
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/primer_run_pr.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ jobs:

# Restore cached Python environment
- name: Restore Python virtual environment
id: cache-venv
id: cache-venv-restore
uses: actions/cache/[email protected]
with:
path: venv
Expand All @@ -75,7 +75,7 @@ jobs:
# Save cached Python environment (explicit because cancel-in-progress: true)
- name: Save Python virtual environment
if: steps.cache-venv.outputs.cache-hit != 'true'
id: cache-venv
id: cache-venv-save
uses: actions/cache/[email protected]
with:
path: venv
Expand Down
Loading