Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicate workflow step ids #9934

Merged
merged 2 commits into from
Sep 19, 2024
Merged

Conversation

jacobtylerwalls
Copy link
Member

Follow-up to 7d60c27.

As always, a little bit of iterating with actions. ;)

@jacobtylerwalls jacobtylerwalls added Maintenance Discussion or action around maintaining pylint or the dev workflow primer Skip news 🔇 This change does not require a changelog entry labels Sep 18, 2024
Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.80%. Comparing base (7d60c27) to head (500a9e5).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #9934   +/-   ##
=======================================
  Coverage   95.80%   95.80%           
=======================================
  Files         174      174           
  Lines       18933    18933           
=======================================
  Hits        18139    18139           
  Misses        794      794           

Copy link
Contributor

🤖 Effect of this PR on checked open source code: 🤖

Effect on home-assistant:
The following messages are now emitted:

  1. unsubscriptable-object:
    Value 'self.hass.data[DOMAIN]' is unsubscriptable
    https://github.com/home-assistant/core/blob/12dbabb849692577beebdb5024fa0f8f5572e4bb/homeassistant/components/media_source/models.py#L89
  2. unsupported-assignment-operation:
    'self.hass.data[DATA_LAST_WAKE_UP]' does not support item assignment
    https://github.com/home-assistant/core/blob/12dbabb849692577beebdb5024fa0f8f5572e4bb/homeassistant/components/assist_pipeline/pipeline.py#L770
  3. unsupported-assignment-operation:
    'self.run.hass.data[DATA_LAST_WAKE_UP]' does not support item assignment
    https://github.com/home-assistant/core/blob/12dbabb849692577beebdb5024fa0f8f5572e4bb/homeassistant/components/assist_pipeline/pipeline.py#L1377
  4. unsupported-assignment-operation:
    'self.hass.data[DOMAIN]' does not support item assignment
    https://github.com/home-assistant/core/blob/12dbabb849692577beebdb5024fa0f8f5572e4bb/homeassistant/components/system_health/__init__.py#L228

Effect on music21:
The following messages are now emitted:

  1. redefined-variable-type:
    Redefinition of thisObject type from music21.note.Note to music21.note.GeneralNote
    https://github.com/cuthbertLab/music21/blob/cfabad142f8d42d94fbfeff497285c7bd4be4db1/music21/humdrum/spineParser.py#L2375

The following messages are no longer emitted:

  1. redefined-variable-type:
    Redefinition of thisObject type from music21.note.Note to music21.note.GeneralNote
    https://github.com/cuthbertLab/music21/blob/cfabad142f8d42d94fbfeff497285c7bd4be4db1/music21/humdrum/spineParser.py#L2378
  2. redefined-variable-type:
    Redefinition of n type from music21.note.Note to music21.note.GeneralNote
    https://github.com/cuthbertLab/music21/blob/cfabad142f8d42d94fbfeff497285c7bd4be4db1/music21/abcFormat/translate.py#L381

Effect on pytest:
The following messages are now emitted:

  1. redefined-variable-type:
    Redefinition of file type from _io.TextIOWrapper to colorama.ansitowin32.StreamWrapper
    https://github.com/pytest-dev/pytest/blob/f8789bcd034035c09f572f61ead943cfa8e30c09/src/_pytest/_io/terminalwriter.py#L84

Effect on psycopg:
The following messages are now emitted:

  1. c-extension-no-member:
    Module 'psycopg.pq._pq_ctypes' has no 'PQnoticeReceiver' member, but source is unavailable. Consider adding this module to extension-pkg-allow-list if you want to perform analysis based on run-time introspection of living objects.
    https://github.com/psycopg/psycopg/blob/fcbe775da0aab8591006918e6c09580241462966/psycopg/psycopg/pq/pq_ctypes.py#L53
  2. too-many-function-args:
    Too many positional arguments for function call
    https://github.com/psycopg/psycopg/blob/fcbe775da0aab8591006918e6c09580241462966/psycopg/psycopg/pq/pq_ctypes.py#L369

The following messages are no longer emitted:

  1. unreachable:
    Unreachable code
    https://github.com/psycopg/psycopg/blob/fcbe775da0aab8591006918e6c09580241462966/psycopg/psycopg/pq/pq_ctypes.py#L557
  2. unreachable:
    Unreachable code
    https://github.com/psycopg/psycopg/blob/fcbe775da0aab8591006918e6c09580241462966/psycopg/psycopg/pq/pq_ctypes.py#L577
  3. unreachable:
    Unreachable code
    https://github.com/psycopg/psycopg/blob/fcbe775da0aab8591006918e6c09580241462966/psycopg/psycopg/pq/pq_ctypes.py#L638
  4. unreachable:
    Unreachable code
    https://github.com/psycopg/psycopg/blob/fcbe775da0aab8591006918e6c09580241462966/psycopg/psycopg/pq/pq_ctypes.py#L734
  5. unreachable:
    Unreachable code
    https://github.com/psycopg/psycopg/blob/fcbe775da0aab8591006918e6c09580241462966/psycopg/psycopg/pq/pq_ctypes.py#L752
  6. unreachable:
    Unreachable code
    https://github.com/psycopg/psycopg/blob/fcbe775da0aab8591006918e6c09580241462966/psycopg/psycopg/pq/pq_ctypes.py#L794
  7. unreachable:
    Unreachable code
    https://github.com/psycopg/psycopg/blob/fcbe775da0aab8591006918e6c09580241462966/psycopg/psycopg/pq/pq_ctypes.py#L1014

This comment was generated for commit 538ba0e

@@ -44,7 +44,7 @@ jobs:

# Create a re-usable virtual environment
- name: Restore Python virtual environment cache
id: cache-venv
id: cache-venv-restore
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should conditionals with the old ID be updated too?

if: steps.cache-venv.outputs.cache-hit != 'true'

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Realized I can probably just delete the new id's I accidentally introduced.

@jacobtylerwalls jacobtylerwalls removed the request for review from DanielNoord September 19, 2024 12:02
@jacobtylerwalls jacobtylerwalls merged commit 7aa4436 into main Sep 19, 2024
34 checks passed
@jacobtylerwalls jacobtylerwalls deleted the jtw/fix-duplicate-step-ids branch September 19, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Discussion or action around maintaining pylint or the dev workflow primer Skip news 🔇 This change does not require a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants