too-few-function-args redundant with no-value-for-parameter
#9882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests β
Additional details and impacted files@@ Coverage Diff @@
## main #9882 +/- ##
=======================================
Coverage 95.80% 95.80%
=======================================
Files 174 174
Lines 18942 18944 +2
=======================================
+ Hits 18147 18149 +2
Misses 795 795
|
This comment has been minimized.
This comment has been minimized.
Pierre-Sassoulas
added
Beta-Blocker π
π©Έ
Pierre-Sassoulas
requested changes
Aug 19, 2024
doc/whatsnew/fragments/9881.bugfix
Outdated
| @@ -0,0 +1,3 @@ | |||
| Remove `too-few-function-args` in favor of the incumbent message `no-value-for-parameter`. | |||
There was a problem hiding this comment.
Let's make the changelog make sense by modifying the existing entry and hide the churn. I'll add the skipnews label
Pierre-Sassoulas
added
the
Skip news π
This comment has been minimized.
This comment has been minimized.
Pierre-Sassoulas
approved these changes
Aug 19, 2024
|
π€ According to the primer, this change has no effect on the checked open source code. π€π This comment was generated for commit 5b9b0d1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
The addition of a new message,
too-few-function-args, in #9847, overlaps (fully) with an existing messageno-value-for-parameter. Because thetoo-few-function-argswas only implemented forisinstance, this PR only seeks to transfer those messages over to the existing messageno-value-for-parameterwith hard-coded argument names forisinstancebecause it's a built-in function.Closes #9881