Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PUP-12071) Increase default value for number_of_facts_soft_limit #9488

Commits on Sep 26, 2024

  1. (PUP-12071) Increase default value for number_of_facts_soft_limit

    This commit increases default value of `number_of_facts_soft_limit` from 2048
    to 2048 * 5 = 10240.
    
    2048 is too small for `number_of_facts_soft_limit` because:
      - The `_package_inventory_1` fact in PE will report packages present by
      multiple providers which results in a package being reported up to 3 times and
      `_package_inventory_1` to be have many more fact values than expected
      - A default PE install reports 5019 fact values which already exceeds the
      previous limit, 2048.
    
    Taking into account the issues above and the feedback from Vox Pupuli in the
    Puppet Community Slack about their fact count, 10240 is a more suitable limit.
    AriaXLi committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    791c216 View commit details
    Browse the repository at this point in the history