(PUP-12071) Increase default value for number_of_facts_soft_limit #9488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If anyone is curious about the feedback Vox Pupuli community members provided: https://puppetcommunity.slack.com/archives/C0W1Y5VL0/p1727195872652739 |
AriaXLi
force-pushed
the
PUP-12071/increase_number_of_facts_soft_limit
branch
from
e26a3ae
to
1bc0fae
Compare
This commit increases default value of `number_of_facts_soft_limit` from 2048 to 2048 * 5 = 10240. 2048 is too small for `number_of_facts_soft_limit` because: - The `_package_inventory_1` fact in PE will report packages present by multiple providers which results in a package being reported up to 3 times and `_package_inventory_1` to be have many more fact values than expected - A default PE install reports 5019 fact values which already exceeds the previous limit, 2048. Taking into account the issues above and the feedback from Vox Pupuli in the Puppet Community Slack about their fact count, 10240 is a more suitable limit.
AriaXLi
force-pushed
the
PUP-12071/increase_number_of_facts_soft_limit
branch
from
1bc0fae
to
791c216
Compare
joshcooper
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit increases default value of
number_of_facts_soft_limitfrom 2048 to 2048 * 5 = 10240.2048 is too small for
number_of_facts_soft_limitbecause:_package_inventory_1fact in PE will report packages present by multiple providers which results in a package being reported up to 3 times and_package_inventory_1to be have many more fact values than expectedTaking into account the issues above and the feedback from Vox Pupuli in the Puppet Community Slack about their fact count, 10240 is a more suitable limit.