Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark some failing 8.3 Windows tests as pending #9368

Merged
merged 2 commits into from
May 29, 2024

Conversation

joshcooper
Copy link
Contributor

@joshcooper joshcooper commented May 29, 2024

Tests started failing with a new GH Windows Server runner 20240526.1.1. The
previous version worked 20240514.1.0. Mark as pending until we can determine the
cause.

As noted in https://learn.microsoft.com/en-us/windows/win32/fileio/naming-a-file

When you create a long file name, Windows may also create a short 8.3 form of the name, called the 8.3 alias or short name, and store it on disk also. This 8.3 aliasing can be disabled for performance reasons either system-wide or for a specified volume, depending on the particular file system.

On many file systems, a file name will contain a tilde (~) within each component of the name that is too long to comply with 8.3 naming rules. ... Not all file systems follow the tilde substitution convention, and systems can be configured to disable 8.3 alias generation even if they normally support it. Therefore, do not make the assumption that the 8.3 alias already exists on-disk.

Also fix how the openssl version is printed on Windows

Tests started failing with a new GH Windows Server runner 20240526.1.1. The
previous version worked 20240514.1.0. Mark as pending until we can determine the
cause.
We were failing to print the openssl version, but the rspec tests continued to
run.

    -e:1: syntax error, unexpected backslash
    puts \"OpenSSL Version - #{OpenSSL:...
         ^
@joshcooper joshcooper force-pushed the pending_win83 branch 2 times, most recently from 498ca19 to 7983df4 Compare May 29, 2024 06:13
@joshcooper joshcooper changed the title Pending win83 Mark some failing 8.3 Windows tests as pending May 29, 2024
@joshcooper joshcooper added the maintenance Maintenance chores are excluded from changelogs label May 29, 2024
@joshcooper joshcooper marked this pull request as ready for review May 29, 2024 06:38
@joshcooper joshcooper requested a review from a team as a code owner May 29, 2024 06:38
@mhashizume
Copy link
Contributor

Do we have a ticket or GitHub Issue to follow up on this?

@mhashizume mhashizume merged commit 77c3d66 into puppetlabs:main May 29, 2024
10 checks passed
@joshcooper joshcooper deleted the pending_win83 branch May 29, 2024 15:40
@joshcooper
Copy link
Contributor Author

@mhashizume yes good thinking, filed as #9371

@joshcooper joshcooper added the backport 7.x Generate a backport PR to 7.x label May 29, 2024
Copy link

Git push to origin failed for 7.x with exitcode 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 7.x Generate a backport PR to 7.x maintenance Maintenance chores are excluded from changelogs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants