Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark some failing 8.3 Windows tests as pending #9368

Merged
merged 2 commits into from
May 29, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/rspec_tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ jobs:
Get-ChildItem Env: | % { Write-Output "$($_.Key): $($_.Value)" }
# list current OpenSSL install
gem list openssl
ruby -ropenssl -e 'puts \"OpenSSL Version - #{OpenSSL::OPENSSL_VERSION}\"; puts \"OpenSSL Library Version - #{OpenSSL::OPENSSL_LIBRARY_VERSION}\"'
ruby -ropenssl -e 'puts "OpenSSL Version - #{OpenSSL::OPENSSL_VERSION}"; puts "OpenSSL Library Version - #{OpenSSL::OPENSSL_LIBRARY_VERSION}"'
Get-Content Gemfile.lock
ruby -v
gem --version
Expand Down
1 change: 1 addition & 0 deletions spec/integration/directory_environments_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@

it 'given an 8.3 style path on Windows, will config print an expanded path',
:if => Puppet::Util::Platform.windows? do
pending("GH runners seem to have disabled 8.3 support")

# ensure an 8.3 style path is set for environmentpath
shortened = Puppet::Util::Windows::File.get_short_pathname(Puppet[:environmentpath])
Expand Down
1 change: 1 addition & 0 deletions spec/integration/node/environment_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ def a_module_in(name, dir)

it "should expand 8.3 paths on Windows when creating an environment",
:if => Puppet::Util::Platform.windows? do
pending("GH runners seem to have disabled 8.3 support")

# asking for short names only works on paths that exist
base = Puppet::Util::Windows::File.get_short_pathname(tmpdir("env_modules"))
Expand Down
2 changes: 2 additions & 0 deletions spec/unit/file_system_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -908,6 +908,8 @@ def increment_counter_in_multiple_processes(file, num_procs, options)
end

it 'should expand a shortened path completely, unlike Ruby File.expand_path' do
pending("GH runners seem to have disabled 8.3 support")

tmp_long_dir = tmpdir('super-long-thing-that-Windows-shortens')
short_path = Puppet::Util::Windows::File.get_short_pathname(tmp_long_dir)

Expand Down
2 changes: 2 additions & 0 deletions spec/unit/util/autoload_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -203,6 +203,8 @@ def with_libdir(libdir)
end

it "autoloads from a directory whose ancestor is Windows 8.3", if: Puppet::Util::Platform.windows? do
pending("GH runners seem to have disabled 8.3 support")

# File.expand_path will expand ~ in the last directory component only(!)
# so create an ancestor directory with a long path
dir = File.join(tmpdir('longpath'), 'short')
Expand Down
Loading