Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PUP-11768) Additional Layout cops #9195

Merged

Commits on Dec 19, 2023

  1. Layout/EndAlignment

    This commit enables the Rubocop Layout/EndAlignment cop and addresses
    all offenses.
    mhashizume committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    7666228 View commit details
    Browse the repository at this point in the history
  2. Layout/ExtraSpacing

    This commit enables the Rubocop Layout/ExtraSpacing cop and addresses
    all offenses.
    mhashizume committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    66d6e8c View commit details
    Browse the repository at this point in the history
  3. Layout/FirstArgumentIndentation

    This commit enables the Rubocop Layout/FirstArgumentIndentation cop and
    addresses all offenses.
    mhashizume committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    9c3a51c View commit details
    Browse the repository at this point in the history
  4. Layout/FirstArrayElementIndentation

    This commit enables the Rubocop Layout/FirstArrayElementIndentation cop
    and addresses all offenses.
    mhashizume committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    b775813 View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2023

  1. Disable Layout cops for defaults

    The defaults file for Puppet is lengthy and has distinctive formatting,
    this commit outright disables all Rubocop Layout cops for the file.
    mhashizume committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    63147bb View commit details
    Browse the repository at this point in the history
  2. Layout/FirstHashElementIndentation

    This commit enables the Rubocop Layout/FirstHashElementIndentation cop
    and addresses all offenses.
    mhashizume committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    fc674de View commit details
    Browse the repository at this point in the history
  3. Layout/FirstParameterIndentation

    This commit enables the Rubocop Layout/FirstParameterIndentation cop and
    addresses all offenses.
    mhashizume committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    6febfd7 View commit details
    Browse the repository at this point in the history
  4. Layout/HashAlignment

    This commit enables the Rubocop Layout/HashAlignment cop and addresses
    all offenses.
    mhashizume committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    a763d24 View commit details
    Browse the repository at this point in the history
  5. Layout/HeredocIndentation

    This commit enables the Rubocop Layout/HeredocIndentation cop and
    addresses all offenses.
    mhashizume committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    65b5421 View commit details
    Browse the repository at this point in the history
  6. Layout/IndentationConsistency

    This commit enables the Rubocop Layout/IndentationConsistency cop and
    addresses all offenses.
    mhashizume committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    e88dde0 View commit details
    Browse the repository at this point in the history
  7. Layout/IndentationStyle

    This commit enables the Rubocop Layout/IndentationStyle cop and
    addresses all offenses.
    mhashizume committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    85ae8a6 View commit details
    Browse the repository at this point in the history
  8. Disable Layout/LineLength cop

    Even with the absurd line length limit of 580,
    Puppet::Util::CommandLine::Trollop was causing a violation of the
    Rubocop Layout/LineLength cop. We have never had this cop enabled before
    and enabling it would likely take quite a lot of work, so we'll disable
    it entirely for now.
    mhashizume committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    f322182 View commit details
    Browse the repository at this point in the history
  9. Layout/IndentationWidth

    This commit enables the Rubocop Layout/IndentationWidth cop and
    addresses all offenses.
    mhashizume committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    64e9603 View commit details
    Browse the repository at this point in the history
  10. Layout/InitialIndentation

    This commit enables the Rubocop Layout/InitialIndentation cop and
    addresses all offenses.
    mhashizume committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    8b3e5c8 View commit details
    Browse the repository at this point in the history
  11. Remove unused method

    The DOT::DOTElement.parent method has been commented out since its
    initial addition in 2006 in 3e3f70e.
    
    The Rubucop Layout/LeadingCommentSpace cop flagged it. Instead of
    addressing that layout issue, this commit removes the method entirely.
    mhashizume committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    14c1314 View commit details
    Browse the repository at this point in the history
  12. Remove unused code

    Some conditional code was commented out in 2015 with b1fde14. The
    Rubocop Layout/LeadingCommentSpace cop flagged it as an issue but,
    because this hasn't been used for over eight years, this commit removes
    the code altogether.
    mhashizume committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    ab36824 View commit details
    Browse the repository at this point in the history
  13. Remove ancient debug statement

    This commit removes a debug statement that was originally added in 2006
    in 18e8e74. The Rubocop Layout/LeadingCommentSpace cop flagged it, but
    it's better to just remove it entirely.
    mhashizume committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    758374a View commit details
    Browse the repository at this point in the history
  14. Remove commented out raise

    One of the conditions for raising an argument error was commented out in
    2014 as part of 2f8428c. The Rubocop Layout/LeadingCommentSpace cop
    flagged this as an issue but, instead of resolving the cop, this
    commit removes the comment entirely.
    mhashizume committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    d181f5f View commit details
    Browse the repository at this point in the history
  15. Layout/LeadingCommentSpace

    This commit enables the Rubocop Layout/LeadingCommentSpace cop and
    addresses all offenses.
    mhashizume committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    19bdb37 View commit details
    Browse the repository at this point in the history