-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(PUP-11768) Additional Layout cops #9195
(PUP-11768) Additional Layout cops #9195
Commits on Dec 19, 2023
-
This commit enables the Rubocop Layout/EndAlignment cop and addresses all offenses.
Configuration menu - View commit details
-
Copy full SHA for 7666228 - Browse repository at this point
Copy the full SHA 7666228View commit details -
This commit enables the Rubocop Layout/ExtraSpacing cop and addresses all offenses.
Configuration menu - View commit details
-
Copy full SHA for 66d6e8c - Browse repository at this point
Copy the full SHA 66d6e8cView commit details -
Layout/FirstArgumentIndentation
This commit enables the Rubocop Layout/FirstArgumentIndentation cop and addresses all offenses.
Configuration menu - View commit details
-
Copy full SHA for 9c3a51c - Browse repository at this point
Copy the full SHA 9c3a51cView commit details -
Layout/FirstArrayElementIndentation
This commit enables the Rubocop Layout/FirstArrayElementIndentation cop and addresses all offenses.
Configuration menu - View commit details
-
Copy full SHA for b775813 - Browse repository at this point
Copy the full SHA b775813View commit details
Commits on Dec 20, 2023
-
Disable Layout cops for defaults
The defaults file for Puppet is lengthy and has distinctive formatting, this commit outright disables all Rubocop Layout cops for the file.
Configuration menu - View commit details
-
Copy full SHA for 63147bb - Browse repository at this point
Copy the full SHA 63147bbView commit details -
Layout/FirstHashElementIndentation
This commit enables the Rubocop Layout/FirstHashElementIndentation cop and addresses all offenses.
Configuration menu - View commit details
-
Copy full SHA for fc674de - Browse repository at this point
Copy the full SHA fc674deView commit details -
Layout/FirstParameterIndentation
This commit enables the Rubocop Layout/FirstParameterIndentation cop and addresses all offenses.
Configuration menu - View commit details
-
Copy full SHA for 6febfd7 - Browse repository at this point
Copy the full SHA 6febfd7View commit details -
This commit enables the Rubocop Layout/HashAlignment cop and addresses all offenses.
Configuration menu - View commit details
-
Copy full SHA for a763d24 - Browse repository at this point
Copy the full SHA a763d24View commit details -
This commit enables the Rubocop Layout/HeredocIndentation cop and addresses all offenses.
Configuration menu - View commit details
-
Copy full SHA for 65b5421 - Browse repository at this point
Copy the full SHA 65b5421View commit details -
This commit enables the Rubocop Layout/IndentationConsistency cop and addresses all offenses.
Configuration menu - View commit details
-
Copy full SHA for e88dde0 - Browse repository at this point
Copy the full SHA e88dde0View commit details -
This commit enables the Rubocop Layout/IndentationStyle cop and addresses all offenses.
Configuration menu - View commit details
-
Copy full SHA for 85ae8a6 - Browse repository at this point
Copy the full SHA 85ae8a6View commit details -
Even with the absurd line length limit of 580, Puppet::Util::CommandLine::Trollop was causing a violation of the Rubocop Layout/LineLength cop. We have never had this cop enabled before and enabling it would likely take quite a lot of work, so we'll disable it entirely for now.
Configuration menu - View commit details
-
Copy full SHA for f322182 - Browse repository at this point
Copy the full SHA f322182View commit details -
This commit enables the Rubocop Layout/IndentationWidth cop and addresses all offenses.
Configuration menu - View commit details
-
Copy full SHA for 64e9603 - Browse repository at this point
Copy the full SHA 64e9603View commit details -
This commit enables the Rubocop Layout/InitialIndentation cop and addresses all offenses.
Configuration menu - View commit details
-
Copy full SHA for 8b3e5c8 - Browse repository at this point
Copy the full SHA 8b3e5c8View commit details -
The DOT::DOTElement.parent method has been commented out since its initial addition in 2006 in 3e3f70e. The Rubucop Layout/LeadingCommentSpace cop flagged it. Instead of addressing that layout issue, this commit removes the method entirely.
Configuration menu - View commit details
-
Copy full SHA for 14c1314 - Browse repository at this point
Copy the full SHA 14c1314View commit details -
Some conditional code was commented out in 2015 with b1fde14. The Rubocop Layout/LeadingCommentSpace cop flagged it as an issue but, because this hasn't been used for over eight years, this commit removes the code altogether.
Configuration menu - View commit details
-
Copy full SHA for ab36824 - Browse repository at this point
Copy the full SHA ab36824View commit details -
Remove ancient debug statement
This commit removes a debug statement that was originally added in 2006 in 18e8e74. The Rubocop Layout/LeadingCommentSpace cop flagged it, but it's better to just remove it entirely.
Configuration menu - View commit details
-
Copy full SHA for 758374a - Browse repository at this point
Copy the full SHA 758374aView commit details -
One of the conditions for raising an argument error was commented out in 2014 as part of 2f8428c. The Rubocop Layout/LeadingCommentSpace cop flagged this as an issue but, instead of resolving the cop, this commit removes the comment entirely.
Configuration menu - View commit details
-
Copy full SHA for d181f5f - Browse repository at this point
Copy the full SHA d181f5fView commit details -
This commit enables the Rubocop Layout/LeadingCommentSpace cop and addresses all offenses.
Configuration menu - View commit details
-
Copy full SHA for 19bdb37 - Browse repository at this point
Copy the full SHA 19bdb37View commit details