(PUP-11768) Additional Layout cops #9195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit enables the Rubocop Layout/EndAlignment cop and addresses all offenses.
This commit enables the Rubocop Layout/ExtraSpacing cop and addresses all offenses.
This commit enables the Rubocop Layout/FirstArgumentIndentation cop and addresses all offenses.
This commit enables the Rubocop Layout/FirstArrayElementIndentation cop and addresses all offenses.
mhashizume
force-pushed
the
PUP-11768/main/additional-layout-cops
branch
2 times, most recently
from
f4c29eb
to
335fc28
Compare
The defaults file for Puppet is lengthy and has distinctive formatting, this commit outright disables all Rubocop Layout cops for the file.
This commit enables the Rubocop Layout/FirstHashElementIndentation cop and addresses all offenses.
This commit enables the Rubocop Layout/FirstParameterIndentation cop and addresses all offenses.
This commit enables the Rubocop Layout/HashAlignment cop and addresses all offenses.
This commit enables the Rubocop Layout/HeredocIndentation cop and addresses all offenses.
This commit enables the Rubocop Layout/IndentationConsistency cop and addresses all offenses.
This commit enables the Rubocop Layout/IndentationStyle cop and addresses all offenses.
Even with the absurd line length limit of 580, Puppet::Util::CommandLine::Trollop was causing a violation of the Rubocop Layout/LineLength cop. We have never had this cop enabled before and enabling it would likely take quite a lot of work, so we'll disable it entirely for now.
This commit enables the Rubocop Layout/IndentationWidth cop and addresses all offenses.
This commit enables the Rubocop Layout/InitialIndentation cop and addresses all offenses.
The DOT::DOTElement.parent method has been commented out since its initial addition in 2006 in 3e3f70e. The Rubucop Layout/LeadingCommentSpace cop flagged it. Instead of addressing that layout issue, this commit removes the method entirely.
Some conditional code was commented out in 2015 with b1fde14. The Rubocop Layout/LeadingCommentSpace cop flagged it as an issue but, because this hasn't been used for over eight years, this commit removes the code altogether.
This commit removes a debug statement that was originally added in 2006 in 18e8e74. The Rubocop Layout/LeadingCommentSpace cop flagged it, but it's better to just remove it entirely.
One of the conditions for raising an argument error was commented out in 2014 as part of 2f8428c. The Rubocop Layout/LeadingCommentSpace cop flagged this as an issue but, instead of resolving the cop, this commit removes the comment entirely.
This commit enables the Rubocop Layout/LeadingCommentSpace cop and addresses all offenses.
mhashizume
force-pushed
the
PUP-11768/main/additional-layout-cops
branch
from
335fc28
to
19bdb37
Compare
cthorn42
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.