Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prometheus monitoring fix - missing label #519

Merged
merged 4 commits into from
Apr 19, 2024

Conversation

Kris686
Copy link
Contributor

@Kris686 Kris686 commented Nov 9, 2023

Issue description

Pulumi kubernetes operator creates Service and ServiceMonitor objects for metrics by itself:
https://github.com/pulumi/pulumi-kubernetes-operator/blob/7d9e693bc6e27f1e3881ce350cdf7fbde71b26be/cmd/manager/main.go#L186C31-L186C31

Service created for metrics requires name label added on pods.

Proposed changes

Added "name" label with {{ template "pulumi-kubernetes-operator.name" . }} value to pulumi-kubernetes-operator Deployment at ReplicaSet level.

impact/no-changelog-required

Copy link

github-actions bot commented Nov 9, 2023

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

Copy link
Contributor

@dirien dirien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Kris686,

thanks for the PR. Can you bump the minor version in the Chart.yaml and add artifacthub.io/changes: text?

Copy link

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@Kris686
Copy link
Contributor Author

Kris686 commented Nov 13, 2023

@dirien done

Hey @Kris686,

thanks for the PR. Can you bump the minor version in the Chart.yaml and add artifacthub.io/changes: text?

Copy link

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@blampe blampe requested a review from dirien December 5, 2023 21:13
Copy link

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

Copy link
Contributor

@dirien dirien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @Kris686 for submitting the PR!

@dirien dirien merged commit 0005b1a into pulumi:master Apr 19, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants