Skip to content

Commit

Permalink
prometheus monitoring fix - missing label (#519)
Browse files Browse the repository at this point in the history
### Issue description

Pulumi kubernetes operator creates Service and ServiceMonitor objects
for metrics by itself:

https://github.com/pulumi/pulumi-kubernetes-operator/blob/7d9e693bc6e27f1e3881ce350cdf7fbde71b26be/cmd/manager/main.go#L186C31-L186C31

Service created for metrics requires name label added on pods.

### Proposed changes

Added "name" label with {{ template "pulumi-kubernetes-operator.name" .
}} value to pulumi-kubernetes-operator Deployment at ReplicaSet level.


impact/no-changelog-required

---------

Co-authored-by: krzysztofer <[email protected]>
Co-authored-by: Engin Diri <[email protected]>
  • Loading branch information
3 people authored Apr 19, 2024
1 parent 4a92c65 commit 0005b1a
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
5 changes: 3 additions & 2 deletions deploy/helm/pulumi-operator/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@ icon: https://www.pulumi.com/logos/brand/avatar-on-white.svg

type: application

version: 0.7.2

version: 0.7.3
appVersion: 1.14.0

keywords:
Expand All @@ -25,7 +26,7 @@ maintainers:
annotations:
artifacthub.io/containsSecurityUpdates: "false"
artifacthub.io/changes: |
- Fix type in CRD
- Added "name" label with pulumi-kubernetes-operator.name value to pulumi-kubernetes-operator Deployment at ReplicaSet level. (#519)
artifacthub.io/images: |
- name: pulumi-kubernetes-operator
image: docker.io/pulumi-kubernetes-operator:v1.14.0
Expand Down
1 change: 1 addition & 0 deletions deploy/helm/pulumi-operator/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ spec:
{{- toYaml . | nindent 8 }}
{{- end }}
labels:
name: {{ template "pulumi-kubernetes-operator.name" . }}
app: {{ template "pulumi-kubernetes-operator.name" . }}
release: {{ .Release.Name }}
{{- include "pulumi-kubernetes-operator.selectorLabels" . | nindent 8 }}
Expand Down

0 comments on commit 0005b1a

Please sign in to comment.