Skip to content

Commit

Permalink
Use non-blocking assignments again
Browse files Browse the repository at this point in the history 
These are currently working only in own Verilator branch
  • Loading branch information
@RootCubed
RootCubed committed Jul 3, 2024
1 parent 2044cad commit 4f3fb94
Show file tree
Hide file tree
Showing 3 changed files with 44 additions and 74 deletions.
15 changes: 6 additions & 9 deletions test/backend/tb_idma_backend.sv
View file
Original file line number Diff line number Diff line change
Expand Up @@ -257,22 +257,19 @@ module tb_idma_backend #(
idma_req.pop_front();

$display("Sending request...");
#TA;
req_valid = '1;
#(TT - TA);
req_valid <= #TA '1;
#TT;
while (req_ready != '1) begin @(posedge clk); #TT; end
@(posedge clk);
$display("Sent request. Waiting for response...");

#TA;
req_valid = '0;
rsp_ready = '1;
#(TT - TA);
req_valid <= #TA '0;
rsp_ready <= #TA '1;
#TT;
while (rsp_valid != '1) begin @(posedge clk); #TT; end
@(posedge clk);

#TA;
rsp_ready = '0;
rsp_ready <= #TA '0;
@(posedge clk);

$display("Request complete.");
Expand Down
69 changes: 27 additions & 42 deletions test/drivers/axi_driver_slave.sv
View file
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ function void reset();
endfunction

task cycle_start;
#(TT - TA);
#TT;
endtask

task cycle_end;
Expand All @@ -52,53 +52,45 @@ endtask
task send_b (
input b_beat_t beat
);
cycle_end();
#TA;
sif.b_id = beat.b_id;
sif.b_resp = beat.b_resp;
sif.b_user = beat.b_user;
sif.b_valid = 1;
sif.b_id <= #TA beat.b_id;
sif.b_resp <= #TA beat.b_resp;
sif.b_user <= #TA beat.b_user;
sif.b_valid <= #TA 1;
cycle_start();
while (sif.b_ready != 1) begin cycle_end(); cycle_start(); end
cycle_end();
#TA;
sif.b_id = '0;
sif.b_resp = '0;
sif.b_user = '0;
sif.b_valid = 0;
sif.b_id <= #TA '0;
sif.b_resp <= #TA '0;
sif.b_user <= #TA '0;
sif.b_valid <= #TA 0;
endtask

/// Issue a beat on the R channel.
task send_r (
input r_beat_t beat
);
cycle_end();
#TA;
sif.r_id = beat.r_id;
sif.r_data = beat.r_data;
sif.r_resp = beat.r_resp;
sif.r_last = beat.r_last;
sif.r_user = beat.r_user;
sif.r_valid = 1;
sif.r_id <= #TA beat.r_id;
sif.r_data <= #TA beat.r_data;
sif.r_resp <= #TA beat.r_resp;
sif.r_last <= #TA beat.r_last;
sif.r_user <= #TA beat.r_user;
sif.r_valid <= #TA 1;
cycle_start();
while (sif.r_ready != 1) begin cycle_end(); cycle_start(); end
cycle_end();
#TA;
sif.r_valid = 0;
sif.r_id = '0;
sif.r_data = '0;
sif.r_resp = '0;
sif.r_last = '0;
sif.r_user = '0;
sif.r_valid <= #TA 0;
sif.r_id <= #TA '0;
sif.r_data <= #TA '0;
sif.r_resp <= #TA '0;
sif.r_last <= #TA '0;
sif.r_user <= #TA '0;
endtask

/// Wait for a beat on the AW channel.
task recv_aw (
output ax_beat_t beat
);
cycle_end();
#TA;
sif.aw_ready = 1;
sif.aw_ready <= #TA 1;
cycle_start();
while (sif.aw_valid != 1) begin cycle_end(); cycle_start(); end
beat = new;
Expand All @@ -115,17 +107,14 @@ task recv_aw (
beat.ax_atop = sif.aw_atop;
beat.ax_user = sif.aw_user;
cycle_end();
#TA;
sif.aw_ready = 0;
sif.aw_ready <= #(TA - 1ns) 0; // Avoid race condition once aw_ready gets set again (Verilator bug?)
endtask

/// Wait for a beat on the W channel.
task recv_w (
output w_beat_t beat
);
cycle_end();
#TA;
sif.w_ready = 1;
sif.w_ready <= #TA 1;
cycle_start();
while (sif.w_valid != 1) begin cycle_end(); cycle_start(); end
beat = new;
Expand All @@ -134,17 +123,14 @@ task recv_w (
beat.w_last = sif.w_last;
beat.w_user = sif.w_user;
cycle_end();
#TA;
sif.w_ready = 0;
sif.w_ready <= #(TA - 1ns) 0; // Avoid race condition once w_ready gets set again (Verilator bug?)
endtask

/// Wait for a beat on the AR channel.
task recv_ar (
output ax_beat_t beat
);
cycle_end();
#TA;
sif.ar_ready = 1;
sif.ar_ready <= #TA 1;
cycle_start();
while (sif.ar_valid != 1) begin cycle_end(); cycle_start(); end
beat = new;
Expand All @@ -161,8 +147,7 @@ task recv_ar (
beat.ax_atop = 'X; // Not defined on the AR channel.
beat.ax_user = sif.ar_user;
cycle_end();
#TA;
sif.ar_ready = 0;
sif.ar_ready <= #(TA - 1ns) 0; // Avoid race condition once ar_ready gets set again (Verilator bug?)
endtask

endmodule
34 changes: 11 additions & 23 deletions test/drivers/obi_driver_slave.sv
View file
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ function void reset();
endfunction

task cycle_start;
#(TT - TA);
#TT;
endtask

task cycle_end;
Expand All @@ -30,62 +30,50 @@ endtask
task recv_r_ar(
output obi_ar_beat addr,
);
cycle_end();
#TA;
sif.gnt = 1;
sif.gnt <= #TA 1;
cycle_start();
while (sif.req != '1 || sif.we != 0) begin cycle_end(); cycle_start(); end
addr = new;
addr.addr = sif.addr;
cycle_end();
#TA;
sif.gnt = 0;
sif.gnt <= #TA 0;
endtask

task recv_w_ar(
output obi_ar_beat data,
);
cycle_end();
#TA;
sif.gnt = 1;
sif.gnt <= #TA 1;
cycle_start();
while (sif.req != '1 || sif.we != 1) begin cycle_end(); cycle_start(); end
data = new;
data.addr = sif.addr;
data.wdata = sif.wdata;
cycle_end();
#TA;
sif.gnt = 0;
sif.gnt <= #TA 0;
endtask

task send_r_rsp(
input obi_r_resp data,
);
cycle_end();
#TA;
sif.rdata = data.data;
sif.rvalid = 1;
sif.rdata <= #TA data.data;
sif.rvalid <= #TA 1;
cycle_start();
// if (ObiCfg.UseRReady) begin
while (sif.rready != 1'b1) begin cycle_end(); cycle_start(); end
// end
cycle_end();
#TA;
sif.rvalid = 0;
sif.rdata = 0;
sif.rvalid <= #TA 0;
sif.rdata <= #TA 0;
endtask

task send_w_rsp();
cycle_end();
#TA;
sif.rvalid = 1;
sif.rvalid <= #TA 1;
cycle_start();
// if (ObiCfg.UseRReady) begin
while (sif.rready != 1'b1) begin cycle_end(); cycle_start(); end
// end
cycle_end();
#TA;
sif.rvalid = 0;
sif.rvalid <= #TA 0;
endtask

endmodule

0 comments on commit 4f3fb94

Please sign in to comment.