Parse start commands in wings #160
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This would replace the need to parse the start commands in the entrypoint so exec could be used instead of eval.
|
@matthewpi is it possible, to merged this and publish a Hotfix? The StopCMD Bug (and yes, it is a Bug, because The only working solution is to use
|
Bumps [golang.org/x/text](https://github.com/golang/text) from 0.3.7 to 0.3.8. - [Release notes](https://github.com/golang/text/releases) - [Commits](golang/text@v0.3.7...v0.3.8) --- updated-dependencies: - dependency-name: golang.org/x/text dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [golang.org/x/net](https://github.com/golang/net) from 0.0.0-20221004154528-8021a29435af to 0.7.0. - [Release notes](https://github.com/golang/net/releases) - [Commits](https://github.com/golang/net/commits/v0.7.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
7 tasks
This would replace the need to parse the start commands in the entrypoint so exec could be used instead of eval.
…se_startup_commands
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This updates the docker client to include the fix added with moby/moby#45962 which solves a breaking change to Go due to CVE-2023-29406.
This would replace the need to parse the start commands in the entrypoint so exec could be used instead of eval.
…se_startup_commands
|
This wasn't merged and the rebase is getting nasty. Going to redo the work and pr to develop |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would replace the need to parse the start commands in the entrypoint so
execcould be used instead ofeval.As seen in the gist below I have tested what it would do to the ark start command
https://gist.githubusercontent.com/parkervcp/db4d2d7b23b48f9aa0eacff79e77d972/raw/377601cd74e4d9c19e58ba0a56086bba438165fe/gistfile1.txt