This repository has been archived by the owner on May 14, 2024. It is now read-only.
Make python invocation work with bash exec #2214
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when using this egg, the "Stop" button in the panel will absolutely not work. This is because the stop button sends a SIGTERM signal to the Bash process, and the Bash process will ignore the SIGTERM without propagating it to the Python process.
By adding
exec
, the Bash process will be completely replaced by the Python process, so the SIGTERM will reach the Python process and it will terminate normally.P.S. I just had a situation where the panel registered the server as completely shut down but the server was still up and running. Please fix it
Description
Checklist for all submissions