-
Notifications
You must be signed in to change notification settings - Fork 880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LICENSE: Add full Apache 2.0 text #2312
Conversation
Changes nothing to the license, but makes it more visible for external projects and in the GitHub interface
1c09543
to
982cfb7
Compare
@@ -1,13 +1,201 @@ | |||
Copyright 2023 Core Mesa Team and contributors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc: @wang-boyu for Mesa-Geo, @adamamer20 for mesa-frames to be consistent with the outcome of this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the official license that’s moved to line 189.
Do you think it should be at the top?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
L189 is in the appendix of the LICENSE text, and is just a guide on how to apply it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am okay with NOTICE if LICENSE points to the NOTICE.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to https://www.apache.org/foundation/license-faq.html#Apply-My-Software, it should be the other way around.
Include a copy of the Apache License, typically in a file called LICENSE, in your work, and consider also including a NOTICE file.
The logic behind having it link to the text and not be the full text is that if there were updates to the Apache license -- we wouldn't have to keep up with those because the spirit would still be the same. I am not necessarily for or against the full license in the repo, but I wanted to share the reason for not including it. |
If there are updates to the license, the version will be bumped to be >2.0. If we want mutable reference to the Apache license, it needs to be Apache-2.0-or-later, which itself is very rarely used. Though in the case of GPL-3.0, it is quite common (GPL-3.0-or-later). |
|
||
http://www.apache.org/licenses/LICENSE-2.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, today is 2024, so this needs to be https://
, not http://
, see https://www.apache.org/foundation/license-faq.html#Apply-My-Software.
Interesting stuff, but more complicated than I like. I think we're fine for now. If anyone wants to pick this up, of course go ahead. |
Created #2318 so that my research here did not go to waste. |
Changes nothing to the license, but makes it more visible for external projects and in the GitHub interface.
Currently:
After this PR: