Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LICENSE: Add full Apache 2.0 text #2312

Closed
wants to merge 1 commit into from
Closed

LICENSE: Add full Apache 2.0 text #2312

wants to merge 1 commit into from

Conversation

EwoutH
Copy link
Member

@EwoutH EwoutH commented Sep 21, 2024

Changes nothing to the license, but makes it more visible for external projects and in the GitHub interface.

Currently:
image
After this PR:
image

@EwoutH EwoutH added maintenance Release notes label ignore-for-release PRs that aren't included in the release notes labels Sep 21, 2024
Changes nothing to the license, but makes it more visible for external projects and in the GitHub interface
@@ -1,13 +1,201 @@
Copyright 2023 Core Mesa Team and contributors
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original text is still necessary, except that it should be renamed to NOTICE, while having the LICENSE text with the new content in this PR. See Apache Spark's NOTICE and LICENSE.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc: @wang-boyu for Mesa-Geo, @adamamer20 for mesa-frames to be consistent with the outcome of this PR.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the official license that’s moved to line 189.

Do you think it should be at the top?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L189 is in the appendix of the LICENSE text, and is just a guide on how to apply it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am okay with NOTICE if LICENSE points to the NOTICE.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to https://www.apache.org/foundation/license-faq.html#Apply-My-Software, it should be the other way around.

Include a copy of the Apache License, typically in a file called LICENSE, in your work, and consider also including a NOTICE file.

@jackiekazil
Copy link
Member

The logic behind having it link to the text and not be the full text is that if there were updates to the Apache license -- we wouldn't have to keep up with those because the spirit would still be the same. I am not necessarily for or against the full license in the repo, but I wanted to share the reason for not including it.

@rht
Copy link
Contributor

rht commented Sep 22, 2024

The logic behind having it link to the text and not be the full text is that if there were updates to the Apache license

If there are updates to the license, the version will be bumped to be >2.0. If we want mutable reference to the Apache license, it needs to be Apache-2.0-or-later, which itself is very rarely used. Though in the case of GPL-3.0, it is quite common (GPL-3.0-or-later).


http://www.apache.org/licenses/LICENSE-2.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, today is 2024, so this needs to be https://, not http://, see https://www.apache.org/foundation/license-faq.html#Apply-My-Software.

@EwoutH
Copy link
Member Author

EwoutH commented Sep 22, 2024

Interesting stuff, but more complicated than I like. I think we're fine for now.

If anyone wants to pick this up, of course go ahead.

@EwoutH EwoutH closed this Sep 22, 2024
@rht rht deleted the license_visibility branch September 22, 2024 19:57
@rht
Copy link
Contributor

rht commented Sep 22, 2024

Created #2318 so that my research here did not go to waste.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-for-release PRs that aren't included in the release notes maintenance Release notes label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants