Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NOTICE and full copy of Apache 2.0 license text #2318

Merged
merged 2 commits into from
Sep 25, 2024
Merged

Conversation

rht
Copy link
Contributor

@rht rht commented Sep 22, 2024

Supersedes #2312.

@jackiekazil
Copy link
Member

RE: This ticket and #2312 -- Why are we doing this? What are we trying to fix?

@rht
Copy link
Contributor Author

rht commented Sep 23, 2024

This is how it is done according to https://www.apache.org/foundation/license-faq.html#Apply-My-Software

Include a copy of the Apache License, typically in a file called LICENSE, in your work, and consider also including a NOTICE file.

It is also valuable to tag each of your source-code files in case they become detached from the LICENSE file. To apply the Apache License to your source-code files, one approach is to attach the following notice to as a comment at the top of each file. Replace the copyright templates with your own identifying information:

@EwoutH
Copy link
Member

EwoutH commented Sep 23, 2024

My initial intention was to adopt the "standard" way GitHub suggests it.

Changes nothing to the license, but makes it more visible for external projects and in the GitHub interface.

Currently:
image
After this PR:
image

@Corvince
Copy link
Contributor

If we use the Apache license we should do it how they suggest -> approved

@rht
Copy link
Contributor Author

rht commented Sep 25, 2024

@jackiekazil can I merge the PR or do you have more reservations?

@jackiekazil
Copy link
Member

Thank you for checking! I am good. Please merge

@rht rht merged commit 1cfd624 into projectmesa:main Sep 25, 2024
11 of 12 checks passed
@rht rht deleted the notice branch September 25, 2024 19:25
@EwoutH EwoutH added the ignore-for-release PRs that aren't included in the release notes label Sep 25, 2024
@EwoutH
Copy link
Member

EwoutH commented Sep 25, 2024

Awsome! GitHub seems to like it:

IMG_1477

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-for-release PRs that aren't included in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants