-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple minor fixes #3
Open
Morlok8k
wants to merge
9
commits into
project-voodoo:master
Choose a base branch
from
Morlok8k:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
2f57257
Update AndroidManifest.xml
mattlgroff fa4f6f1
Merge remote-tracking branch 'mattlgroff/master'
Morlok8k c0c9728
updated android:targetSdkVersion
Morlok8k 418aa80
fixed mispelled word
Morlok8k 9a0c65d
fixed a bunch of warnings
Morlok8k 034f4ba
updated to target android 4.2.2
Morlok8k fc2114b
added more checks to check for alternate superuser apps.
Morlok8k f169484
updated .gitignore to add more generated files
Morlok8k f9e0fd5
version bump
Morlok8k File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,7 +11,10 @@ | |
# generated GUI files | ||
*R.java | ||
|
||
lint.xml | ||
|
||
BuildConfig.java | ||
|
||
proguard/ | ||
bin/ | ||
.settings/ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,4 +8,4 @@ | |
# project structure. | ||
|
||
# Project target. | ||
target=android-15 | ||
target=android-17 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,14 @@ | ||
<?xml version="1.0" encoding="utf-8"?> | ||
<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android" | ||
xmlns:tools="http://schemas.android.com/tools" | ||
android:layout_width="match_parent" | ||
android:layout_height="match_parent" | ||
android:orientation="vertical" > | ||
<ImageView | ||
android:id="@+id/imageView1" | ||
android:layout_width="wrap_content" | ||
android:layout_height="wrap_content" | ||
android:src="@android:drawable/checkbox_on_background" > | ||
android:src="@android:drawable/checkbox_on_background" | ||
tools:ignore="ContentDescription" > | ||
</ImageView> | ||
</LinearLayout> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,14 @@ | ||
<?xml version="1.0" encoding="utf-8"?> | ||
<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android" | ||
xmlns:tools="http://schemas.android.com/tools" | ||
android:layout_width="match_parent" | ||
android:layout_height="match_parent" | ||
android:orientation="vertical" > | ||
<ImageView | ||
android:id="@+id/imageView1" | ||
android:layout_width="wrap_content" | ||
android:layout_height="wrap_content" | ||
android:src="@android:drawable/checkbox_off_background" > | ||
android:src="@android:drawable/checkbox_off_background" | ||
tools:ignore="ContentDescription" > | ||
</ImageView> | ||
</LinearLayout> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -118,7 +118,16 @@ private void ensureAttributeUtilsAvailability() { | |
|
||
public void analyzeSu() { | ||
isRooted = detectValidSuBinaryInPath(); | ||
isSuperuserAppInstalled = isSuperUserApkinstalled(); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. √ There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I |
||
isSuperuserAppInstalled = isChainsDD_SuperUserApkinstalled(); | ||
|
||
if (isSuperuserAppInstalled == false) { | ||
isSuperuserAppInstalled = isChainfire_SuperSUApkinstalled(); | ||
} | ||
|
||
if (isSuperuserAppInstalled == false) { | ||
isSuperuserAppInstalled = isKoush_SuperUserApkinstalled(); | ||
} | ||
|
||
isSuProtected = isSuProtected(); | ||
} | ||
|
||
|
@@ -180,7 +189,7 @@ private Boolean detectValidSuBinaryInPath() { | |
return false; | ||
} | ||
|
||
private Boolean isSuperUserApkinstalled() { | ||
private Boolean isChainsDD_SuperUserApkinstalled() { | ||
try { | ||
mContext.getPackageManager().getPackageInfo("com.noshufou.android.su", 0); | ||
Log.d(TAG, "Superuser.apk installed"); | ||
|
@@ -190,4 +199,24 @@ private Boolean isSuperUserApkinstalled() { | |
} | ||
} | ||
|
||
private Boolean isChainfire_SuperSUApkinstalled() { | ||
try { | ||
mContext.getPackageManager().getPackageInfo("eu.chainfire.supersu", 0); | ||
Log.d(TAG, "Superuser.apk installed"); | ||
return true; | ||
} catch (NameNotFoundException e) { | ||
return false; | ||
} | ||
} | ||
|
||
private Boolean isKoush_SuperUserApkinstalled() { | ||
try { | ||
mContext.getPackageManager().getPackageInfo("com.koushikdutta.superuser", 0); | ||
Log.d(TAG, "Superuser.apk installed"); | ||
return true; | ||
} catch (NameNotFoundException e) { | ||
return false; | ||
} | ||
} | ||
|
||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.