Multiple minor fixes

[Morlok8k]

Yes, its not 4.3 compatible, but it still fixes a bunch of little issues i've noticed

[supercurio]

Hey hello Morlok8k, thanks very much for those changes I'll review them
quickly and merge.

I'm sad the app cannot work anymore for it's main purpose on 4.3 and I
think before publishing an update something should be done about addressing
this, like a fat warning to people in 4.2.x explaining them that if they
update and their boot-loader is locked, possibly preventing firmware
downgrade it's possible they will lose root forever.

On Wed, Aug 7, 2013 at 3:06 AM, Morlok8k [email protected] wrote:

Yes, its not 4.3 compatible, but it still fixes a bunch of little issues

i've noticed

You can merge this Pull Request by running

git pull https://github.com/Morlok8k/ota-rootkeeper-app master

Or view, comment on, or merge it at:

#3
Commit Summary

• Update AndroidManifest.xml
• Merge remote-tracking branch 'mattlgroff/master'
• updated android:targetSdkVersion
• fixed mispelled word
• fixed a bunch of warnings
• updated to target android 4.2.2
• added more checks to check for alternate superuser apps.
• updated .gitignore to add more generated files
• version bump

File Changes

• M .gitignorehttps://github.com/Multiple minor fixes #3/files#diff-0(3)
• M AndroidManifest.xmlhttps://github.com/Multiple minor fixes #3/files#diff-1(10)
• M project.propertieshttps://github.com/Multiple minor fixes #3/files#diff-2(2)
• M res/layout/status_available.xmlhttps://github.com/Multiple minor fixes #3/files#diff-3(4)
• M res/layout/status_unavailable.xmlhttps://github.com/Multiple minor fixes #3/files#diff-4(4)
• M res/menu/main_menu.xmlhttps://github.com/Multiple minor fixes #3/files#diff-5(2)
• M res/values/strings.xmlhttps://github.com/Multiple minor fixes #3/files#diff-6(4)
• M src/org/projectvoodoo/otarootkeeper/backend/Device.javahttps://github.com/Multiple minor fixes #3/files#diff-7(33)

Patch Links:

• https://github.com/project-voodoo/ota-rootkeeper-app/pull/3.patch
• https://github.com/project-voodoo/ota-rootkeeper-app/pull/3.diff

François Simond
Android developer, open source enthusiast.

http://twitter.com/supercurio
http://project-voodoo.org/

[Morlok8k]

Yes, you should put a nice big warning on the app saying it doesn't work on 4.3.

I actually made these changes months ago, but forgot to submit a pull request.

maybe with some research, people can find a way to securely protect root. 4.3 is really new.

[supercurio]

Yep. I studied the question right away but the security model is really
different, enough to break the previous paradigms.
And on the Nexuses, attempts to keep root make the OTA fail as it cannot
rewrite or delete some immutable files.

On some other devices, it might be possible to keep root thanks to the fact
they use different OTA mechanisms tho.

On Wed, Aug 7, 2013 at 3:23 AM, Morlok8k [email protected] wrote:

Yes, you should put a nice big warning on the app saying it doesn't work
on 4.3.

I actually made these changes months ago, but forgot to submit a pull
request.

maybe with some research, people can find a way to securely protect root.
4.3 is really new.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/3#issuecomment-22223947
.

François Simond
Android developer, open source enthusiast.

http://twitter.com/supercurio
http://project-voodoo.org/

[Rwadxvv]

8wui

[Rwadxvv]

√

[Rwadxvv]

I

[Yaf532]

Suggested change

	<uses-permission android:name="android.permission.ACCESS_SUPERUSER" />
	<uses-permission android:name="android.permission.ACCESS_- SUPERUSER"