Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pest): be inclusive of unicode characters in identifiers to introduce better warnings #4959

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

test in validate

41d42b9
Select commit
Loading
Failed to load commit list.
Draft

fix(pest): be inclusive of unicode characters in identifiers to introduce better warnings #4959

test in validate
41d42b9
Select commit
Loading
Failed to load commit list.
CodSpeed HQ / CodSpeed Performance Analysis failed Jul 18, 2024 in 0s

Performance Regression: -9.82%

Summary

❌ 3 regressions
✅ 8 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main fix/handle-non-ascii-field-idents Change
validate (large) 63.5 ms 70.5 ms -9.82%
validate (medium) 14 ms 15.3 ms -8.76%
validate (small) 2.1 ms 2.2 ms -8.69%