Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(pest): be inclusive of unicode characters in identifiers to introduce better warnings #4959

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

fix(pest): be inclusive of unicode characters in identifiers to introduce better warnings #4959

wants to merge 5 commits into from

Conversation

Druue
Copy link
Contributor

@Druue Druue commented Jul 18, 2024 •
edited
Loading

@Druue Druue added this to the 5.18.0 milestone Jul 18, 2024
@Druue Druue requested a review from a team as a code owner July 18, 2024 11:11
@Druue Druue requested review from jkomyno and removed request for a team July 18, 2024 11:11
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jul 18, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #4959 will degrade performances by 9.82%

Comparing fix/handle-non-ascii-field-idents (41d42b9) with main (15f8fe4)

Summary

❌ 3 regressions
✅ 8 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main fix/handle-non-ascii-field-idents Change
❌ validate (large) 63.5 ms 70.5 ms -9.82%
❌ validate (medium) 14 ms 15.3 ms -8.76%
❌ validate (small) 2.1 ms 2.2 ms -8.69%

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 18, 2024 •
edited
Loading

WASM Query Engine file Size

Engine This PR Base branch Diff
Postgres 2.063MiB 2.056MiB 7.057KiB
Postgres (gzip) 822.723KiB 820.390KiB 2.334KiB
Mysql 2.033MiB 2.026MiB 7.057KiB
Mysql (gzip) 810.864KiB 808.377KiB 2.487KiB
Sqlite 1.932MiB 1.925MiB 7.057KiB
Sqlite (gzip) 771.007KiB 768.535KiB 2.473KiB

@Druue Druue marked this pull request as draft July 18, 2024 11:47
@Druue Druue changed the title fix(pest): be inclusive of unicode characters in identifiers fix(pest): be inclusive of unicode characters in identifiers to introduce better warnings Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkomyno jkomyno Awaiting requested review from jkomyno jkomyno is a code owner automatically assigned from prisma/orm-rust

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.18.0
Development

Successfully merging this pull request may close these issues.
1 participant
@Druue