Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix panic kills running engine in query-engine-tests #4499

Merged
merged 11 commits into from
Nov 29, 2023
Merged

Fix panic kills running engine in query-engine-tests #4499

merged 11 commits into from
Nov 29, 2023

Commits on Nov 28, 2023

  1. I didn't have wasm-pack installed, let's fix that

    @miguelff
    miguelff authored and Miguel Fernández committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    4244e8d View commit details
    Browse the repository at this point in the history

  2. Update wasm-bindgen-futures to 0.4.39 

    This includes rustwasm/wasm-bindgen#3203 that use queueMicrotask
to transalate spawn_local rust code.

This has fixed rustwasm/wasm-bindgen#2392 which was an issue about not being able to catch async wasm traps. This might (or not) have an effect on the issue we are trying to solve in here.
    @miguelff
    miguelff authored and Miguel Fernández committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    16eaea6 View commit details
    Browse the repository at this point in the history

  3. Revert "Update wasm-bindgen-futures to 0.4.39" 

    This reverts commit 9a494dc.
    @miguelff
    miguelff authored and Miguel Fernández committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    8713116 View commit details
    Browse the repository at this point in the history

  4. Restart executor when it dies

    @miguelff
    miguelff authored and Miguel Fernández committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    71e60e9 View commit details
    Browse the repository at this point in the history

  5. Document Restartable

    @miguelff
    miguelff authored and Miguel Fernández committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    da69268 View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2023

  1. Remove async_panic_to_js_error in WASM query engine

    @miguelff
    miguelff committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    a8e99cc View commit details
    Browse the repository at this point in the history

  2. Rename p -> process

    @miguelff
    miguelff committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    04d6c7b View commit details
    Browse the repository at this point in the history

  3. Use tokio::sync::RwLock rather than futures::lock::Mutex

    @miguelff
    miguelff committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    7b31e86 View commit details
    Browse the repository at this point in the history

  4. Better error messaging

    @miguelff
    miguelff committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    4667478 View commit details
    Browse the repository at this point in the history

  5. Fixing clippy

    @miguelff
    miguelff committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    22042e1 View commit details
    Browse the repository at this point in the history

  6. Exclude unit tests for wasm32 when compiling the binary for other arc… 

    …hitectures
    @miguelff
    miguelff committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    ff1b78c View commit details
    Browse the repository at this point in the history