Fix panic kills running engine in query-engine-tests

[miguelff]

This PR allows to continue running the tests after the node process has aborted due to a panic, rather than exiting.

Closes: https://github.com/prisma/team-orm/issues/633

[codspeed-hq]

CodSpeed Performance Report

Merging #4499 will not alter performance

_{Comparing mff/633-panics (ff1b78c) with feat/query-engine-wasm32-unknown-unknown (269998d)}

Summary

✅ 11 untouched benchmarks

[miguelff]

There a many unrelated test failures after having rebased #4466

However ./build.sh && cargo test -p query-engine-tests new::interactive_tx -- --test-threads=1

Runs all the interactive_tx tests rather than failing on the first. See output:

output.txt

[miguelff]

I might need to adjust this, Given the last few lines of the test report
output.txt

 params=[] result="success" item_type="query" is_query=true duration_ms=8
thread 'new::interactive_tx::itx_isolation::spacing_doesnt_matter' panicked at query-engine/connector-test-kit-rs/query-tests-setup/src/lib.rs:290:35:
called `Result::unwrap()` on an `Err` value: External(Error { code: ServerError(500), message: "Server error", data: None })


failures:
    new::interactive_tx::interactive_tx::basic_commit_workflow
    new::interactive_tx::interactive_tx::basic_rollback_workflow
    new::interactive_tx::interactive_tx::batch_queries_failure
    new::interactive_tx::interactive_tx::batch_queries_rollback
    new::interactive_tx::interactive_tx::batch_queries_success
    new::interactive_tx::interactive_tx::commit_after_rollback
    new::interactive_tx::interactive_tx::double_commit
    new::interactive_tx::interactive_tx::double_rollback
    new::interactive_tx::interactive_tx::multiple_tx
    new::interactive_tx::interactive_tx::no_auto_rollback
    new::interactive_tx::interactive_tx::raw_queries
    new::interactive_tx::interactive_tx::rollback_after_commit
    new::interactive_tx::interactive_tx::tx_expiration_cycle
    new::interactive_tx::interactive_tx::tx_expiration_failure_cycle
    new::interactive_tx::interactive_tx::write_conflict
    new::interactive_tx::itx_isolation::basic_serializable
    new::interactive_tx::itx_isolation::casing_doesnt_matter
    new::interactive_tx::itx_isolation::invalid_isolation
    new::interactive_tx::itx_isolation::spacing_doesnt_matter

test result: FAILED. 1 passed; 19 failed; 0 ignored; 0 measured; 1563 filtered out; finished in 4.18s

error: test failed, to rerun pass `-p query-engine-tests --test query_engine_tests

[SevInf]

Approving with a few non-blocking questions/suggestions

[SevInf]

Oh, one more thing, could we remove async_panic_to_js_error from wasm engine as well, just not to give anyone false impression that it does anything?

[SevInf]

After playing with it a little bit, it does not seem like we see output/backtrace of a panic anymore. Is there a quick way in which we could preserve it?

[miguelff]

Working on your feedback, will request review again when done.

[miguelff]

After playing with it a little bit, it does not seem like we see output/backtrace of a panic anymore. Is there a quick way in which we could preserve it?

I'm not sure I can reproduce:

cargo test -p query-engine-tests new::interactive_tx::interactive_tx -- --test-threads=1 2>&1 > test_run.txt

leads to test_run.txt, which has the when the tests run (rather than being reported at the end)

    Finished test [unoptimized + debuginfo] target(s) in 0.69s
     Running unittests src/lib.rs (target/debug/deps/query_engine_tests-2c035a45b52b38a9)

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

     Running tests/query_engine_tests.rs (target/debug/deps/query_engine_tests-31e850527f6b4e11)

running 15 tests
test new::interactive_tx::interactive_tx::basic_commit_workflow ... panicked at /Users/miguel/.cargo/registry/src/index.crates.io-6f17d22bba15001f/rand-0.8.5/src/rngs/thread.rs:72:17:
could not initialize thread_rng: Node.js ES modules are not directly supported, see https://docs.rs/getrandom#nodejs-es-module-support

Stack:

Error
    at __wbg_new_abda76e883ba8a5f (file:///Users/miguel/GitHub/prisma/prisma-engines/query-engine/query-engine-wasm/pkg/query_engine_bg.js:636:17)
    at wasm://wasm/010afe96:wasm-function[2584]:0x31c842
    at wasm://wasm/010afe96:wasm-function[4591]:0x35a8ba
    at wasm://wasm/010afe96:wasm-function[1467]:0x2aa7f8
    at wasm://wasm/010afe96:wasm-function[3183]:0x3362f7
    at wasm://wasm/010afe96:wasm-function[2781]:0x326028
    at wasm://wasm/010afe96:wasm-function[1002]:0x260378
    at wasm://wasm/010afe96:wasm-function[4048]:0x34fb85
    at wasm://wasm/010afe96:wasm-function[126]:0x7f6fe
    at wasm://wasm/010afe96:wasm-function[504]:0x1b9b9a


wasm://wasm/010afe96:1


RuntimeError: unreachable
    at wasm://wasm/010afe96:wasm-function[2584]:0x31c906
    at wasm://wasm/010afe96:wasm-function[4591]:0x35a8ba
    at wasm://wasm/010afe96:wasm-function[1467]:0x2aa7f8
    at wasm://wasm/010afe96:wasm-function[3183]:0x3362f7
    at wasm://wasm/010afe96:wasm-function[2781]:0x326028
    at wasm://wasm/010afe96:wasm-function[1002]:0x260378
    at wasm://wasm/010afe96:wasm-function[4048]:0x34fb85
    at wasm://wasm/010afe96:wasm-function[126]:0x7f6fe
    at wasm://wasm/010afe96:wasm-function[504]:0x1b9b9a
    at wasm://wasm/010afe96:wasm-function[143]:0x9dcec

Node.js v18.17.0
FAILED
test new::interactive_tx::interactive_tx::basic_rollback_workflow ... panicked at /Users/miguel/.cargo/registry/src/index.crates.io-6f17d22bba15001f/rand-0.8.5/src/rngs/thread.rs:72:17:
could not initialize thread_rng: Node.js ES modules are not directly supported, see https://docs.rs/getrandom#nodejs-es-module-support

Stack:
[...]