Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(driver-adapters): rename preview feature jsConnectors -> driverAdapters #4201

Merged
merged 2 commits into from
Sep 5, 2023
Merged

feat(driver-adapters): rename preview feature jsConnectors -> driverAdapters #4201

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
303465c
Revert "feat(driver-adapters): revert preview feature name change"
jkomyno Sep 5, 2023
cfe5d53
feat(driver-adapters): update preview feature in schemas
jkomyno Sep 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions psl/psl-core/src/common/preview_features.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ features!(
NamedConstraints,
NApi,
NativeTypes,
JsConnectors,
DriverAdapters,
OrderByAggregateGroup,
OrderByNulls,
OrderByRelation,
Expand Down Expand Up @@ -124,7 +124,7 @@ pub const ALL_PREVIEW_FEATURES: FeatureMap = FeatureMap {
| UncheckedScalarInputs
}),
hidden: enumflags2::make_bitflags!(PreviewFeature::{
JsConnectors
DriverAdapters
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: We need to remove it from hidden "later"

Copy link
Contributor

@janpio janpio Sep 5, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now added: https://www.notion.so/prismaio/Node-Drivers-All-the-phases-0e9090072ae64f5b85b94ed9b36750b8?pvs=4#045d030ebfcb41ca9b75e488b74b2049

}),
};

Expand Down
2 changes: 1 addition & 1 deletion query-engine/driver-adapters/js/smoke-test-js/prisma/mysql/schema.prisma
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
generator client {
provider = "prisma-client-js"
previewFeatures = ["jsConnectors"]
previewFeatures = ["driverAdapters"]
}

datasource db {
Expand Down
2 changes: 1 addition & 1 deletion query-engine/driver-adapters/js/smoke-test-js/prisma/postgres/schema.prisma
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
generator client {
provider = "prisma-client-js"
previewFeatures = ["jsConnectors"]
previewFeatures = ["driverAdapters"]
}

datasource db {
Expand Down
5 changes: 2 additions & 3 deletions query-engine/query-engine-node-api/src/engine.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,11 +174,10 @@ impl QueryEngine {

let mut connector_mode = ConnectorMode::Rust;

// TODO: https://github.com/prisma/team-orm/issues/340
if !preview_features.contains(PreviewFeature::JsConnectors) {
if !preview_features.contains(PreviewFeature::DriverAdapters) {
tracing::info!(
"Please enable the {} preview feature to use driver adapters.",
PreviewFeature::JsConnectors
PreviewFeature::DriverAdapters
);
} else {
#[cfg(feature = "driver-adapters")]
Expand Down
Loading