Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(driver-adapters): rename preview feature jsConnectors -> driverAdapters #4201

Merged
merged 2 commits into from
Sep 5, 2023

Conversation

jkomyno
Copy link
Contributor

@jkomyno jkomyno commented Sep 5, 2023

This PR is based off #4174.
It contributes to https://github.com/prisma/team-orm/issues/327.

@jkomyno jkomyno marked this pull request as ready for review September 5, 2023 11:54
@jkomyno jkomyno requested a review from a team as a code owner September 5, 2023 11:54
@jkomyno jkomyno added this to the 5.3.0 milestone Sep 5, 2023
@@ -124,7 +124,7 @@ pub const ALL_PREVIEW_FEATURES: FeatureMap = FeatureMap {
| UncheckedScalarInputs
}),
hidden: enumflags2::make_bitflags!(PreviewFeature::{
JsConnectors
DriverAdapters
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: We need to remove it from hidden "later"

Copy link
Contributor

@janpio janpio Sep 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codspeed-hq
Copy link

codspeed-hq bot commented Sep 5, 2023

CodSpeed Performance Report

Merging #4201 will not alter performance

Comparing feat/driver-adapters-feature (cfe5d53) with feat/node-drivers-dx (437eef0)

Summary

✅ 11 untouched benchmarks

@jkomyno jkomyno merged commit 3e5d350 into feat/node-drivers-dx Sep 5, 2023
53 of 54 checks passed
@jkomyno jkomyno deleted the feat/driver-adapters-feature branch September 5, 2023 15:35
jkomyno added a commit that referenced this pull request Sep 5, 2023
* fix(js-connectors): [PlanetScale] enable event logs in transactions

* chore(js-connectors): [Neon / Pg] add skeleton for event logs in transactions

* chore(js-connectors): add "@prisma/client" smoke tests, fix LibraryEngine types

* feat(js-connectors): add "@prisma/client" mini test suite

* fix(js-connectors): [Neon / pg] transaction event logs

* chore(js-connectors): simplify transaction options

* chore(js-connectors): simplify startTransaction signature

* chore(js-connectors): turn smoke-test-js into an ESModule

* feat(js-connectors): use "jsConnectors" preview feature

* feat(driver-adapters): rename from js-connectors

* feat(driver-adapters): revert preview feature name change

* feat(driver-adapters): apply new DX to TypeScript packages

* feat(driver-adapters): apply new DX to smoke tests

* feat(driver-adapters): minor leftovers

* feat(driver-adapters): implement PR comments

* feat(driver-adapters): rename "@jkomyno/adapter-utils" into "@jkomyno/driver-adapter-utils"

* feat(driver-adapters): simplify tsconfig to use "moduleResolution": "Bundler", update outdated package name

* chore: update version of PlanetScale adapter

* [skip ci] chore(driver-adapters): rename "PrismaPostgres" -> "PrismaPg", bump versions

* [skip ci] chore(driver-adapters): update preview feature in schemas

* feat(driver-adapters): rename preview feature `jsConnectors` -> `driverAdapters` (#4201)

* Revert "feat(driver-adapters): revert preview feature name change"

This reverts commit 90dc3ec.

* feat(driver-adapters): update preview feature in schemas
tomhoule added a commit that referenced this pull request Sep 7, 2023
tomhoule added a commit that referenced this pull request Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants