Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgraded to spfx-v1.20.0 #5271

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions samples/react-flow-dashboard/.eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ module.exports = {
//
// CONFIGURATION: By default, these are banned: String, Boolean, Number, Object, Symbol
'@typescript-eslint/ban-types': [
1,
0,
{
'extendDefaults': false,
'types': {
Expand Down Expand Up @@ -126,7 +126,7 @@ module.exports = {
//
// STANDARDIZED BY: @typescript-eslint\eslint-plugin\dist\configs\recommended.json
'@typescript-eslint/no-unused-vars': [
1,
0,
{
'vars': 'all',
// Unused function arguments often indicate a mistake in JavaScript code. However in TypeScript code,
Expand Down Expand Up @@ -160,6 +160,7 @@ module.exports = {
// STANDARDIZED BY: @typescript-eslint\eslint-plugin\dist\configs\recommended.json
// Rationale to disable: declaration of empty interfaces may be helpful for generic types scenarios
'@typescript-eslint/no-empty-interface': 0,
'@typescript-eslint/no-unused-expressions': 0,
// RATIONALE: This rule warns if setters are defined without getters, which is probably a mistake.
'accessor-pairs': 1,
// RATIONALE: In TypeScript, if you write x["y"] instead of x.y, it disables type checking.
Expand Down
Binary file added samples/react-flow-dashboard/.nvmrc
Binary file not shown.
6 changes: 3 additions & 3 deletions samples/react-flow-dashboard/.yo-rc.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,12 @@
"@microsoft/generator-sharepoint": {
"plusBeta": false,
"isCreatingSolution": true,
"nodeVersion": "16.18.1",
"nodeVersion": "18.18.2",
"sdksVersions": {
"@microsoft/microsoft-graph-client": "3.0.2",
"@microsoft/teams-js": "2.9.1"
"@microsoft/teams-js": "2.24.0"
},
"version": "1.17.4",
"version": "1.20.0",
"libraryName": "react-flow-dashboard",
"libraryId": "a55dc82b-3833-4250-9563-c6ab960ec7ae",
"environment": "spo",
Expand Down
5 changes: 3 additions & 2 deletions samples/react-flow-dashboard/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ This web part demonstrates displaying the list of flows and perform some basic a
| Every SPFx version is only compatible with specific version(s) of Node.js. In order to be able to build this sample, please ensure that the version of Node on your workstation matches one of the versions listed in this section. This sample will not work on a different version of Node.|
|Refer to <https://aka.ms/spfx-matrix> for more information on SPFx compatibility. |

![SPFx 1.17.4](https://img.shields.io/badge/SPFx-1.17.4-green.svg)
![Node.js v16 | v14](https://img.shields.io/badge/Node.js-v16%20%7C%20v14-green.svg)
![SPFx 1.20.0](https://img.shields.io/badge/SPFx-1.20.0-green.svg)
![Node.js v18.18.2 | v14](https://img.shields.io/badge/Node.js-v18.18.2-green.svg)
![Compatible with SharePoint Online](https://img.shields.io/badge/SharePoint%20Online-Compatible-green.svg)
![Does not work with SharePoint 2019](https://img.shields.io/badge/SharePoint%20Server%202019-Incompatible-red.svg "SharePoint Server 2019 requires SPFx 1.4.1 or lower")
![Does not work with SharePoint 2016 (Feature Pack 2)](https://img.shields.io/badge/SharePoint%20Server%202016%20(Feature%20Pack%202)-Incompatible-red.svg "SharePoint Server 2016 Feature Pack 2 requires SPFx 1.1")
Expand Down Expand Up @@ -66,6 +66,7 @@ If the problem still persists,
Version|Date|Comments
-------|----|--------
1.0|August 3, 2023|Initial release
2.0|October 10, 2024|Upgraded to SharePoint Framework v1.20.0

## Help

Expand Down
6 changes: 3 additions & 3 deletions samples/react-flow-dashboard/config/package-solution.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"solution": {
"name": "react-flow-dashboard-client-side-solution",
"id": "a55dc82b-3833-4250-9563-c6ab960ec7ae",
"version": "1.0.0.0",
"version": "2.0.0.0",
"includeClientSideAssets": true,
"skipFeatureDeployment": true,
"isDomainIsolated": false,
Expand All @@ -12,7 +12,7 @@
"websiteUrl": "https://github.com/NishkalankBezawada",
"privacyUrl": "",
"termsOfUseUrl": "",
"mpnId": "Undefined-1.17.4"
"mpnId": "Undefined-1.20.0"
},
"webApiPermissionRequests": [
{
Expand Down Expand Up @@ -40,7 +40,7 @@
"title": "react-flow-dashboard Feature",
"description": "The feature that activates elements of the react-flow-dashboard solution.",
"id": "6302f19a-1bd1-4021-8c94-6fe9ce9f3410",
"version": "1.0.0.0"
"version": "2.0.0.0"
}
]
},
Expand Down
6 changes: 6 additions & 0 deletions samples/react-flow-dashboard/gulpfile.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,10 @@ build.rig.getTasks = function () {
return result;
};

/* fast-serve */
const { addFastServe } = require("spfx-fast-serve-helpers");
addFastServe(build);
/* end of fast-serve */

build.initialize(require('gulp'));

Loading
Loading