Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgraded to spfx-v1.20.0 #5271

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

NishkalankBezawada
Copy link
Contributor

@NishkalankBezawada NishkalankBezawada commented Oct 1, 2024

  • New sample
  • Bug fix/update
  • Related issues: fixes #X, partially #Y, mentioned in #Z

What's in this Pull Request?

Upgraded the SharePoint Framework to v1.20.0

Node Version

Node.js v18.18.2 | v14

SPFx Version

SPFx 1.20.0

Checklist

This checklist is used to automatically pre-process your pull request; It is meant to help process pull requests in a timely manner, rather than hoops to jump through.

Put an x in all the items that apply ([x], no spaces between the [, the x, and the ] ). Make notes next to any that haven't been addressed.

  • My pull request affects only ONE sample.
  • My sample builds without any warnings
  • I have updated the README.md file's Version history. For new samples, created a new README.md file matching this template
  • My README.md has at least one static high-resolution screenshot (i.e. not a GIF) located in the assets folder.
  • My README.md contains complete setup instructions, including pre-requisites and permissions required
  • My solution includes a .nvmrc file indicating the version of Node.js

Thanks,
Nishkalank Bezawada

@Adam-it Adam-it self-assigned this Oct 1, 2024
@Adam-it
Copy link
Contributor

Adam-it commented Oct 1, 2024

Thank you for opening a PR to our samples repo and helping us upgrade our project 👍
We will try to review this PR ASAP

Copy link
Contributor

@Adam-it Adam-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NishkalankBezawada awesome work so far 👏👏👏👏
I had a quick check end left some comments I think we should resolve before merging. Please do give them a double check before we proceed 🙏

Also I was unable to successfully build the project 🤔
image

Also:
Please also update the sample.json file in assets folder
This file holds the metadata of the sample which is present in the MS sample gallery. We should update the updateDateTime filed and

{
                "key": "SPFX-VERSION",
                "value": "1.17.4"
}

as well to "value": "1.20.0"

samples/react-flow-dashboard/package.json Show resolved Hide resolved
samples/react-flow-dashboard/package.json Show resolved Hide resolved
@Adam-it Adam-it marked this pull request as draft October 6, 2024 21:25
@NishkalankBezawada
Copy link
Contributor Author

Hey @Adam-it

I have resolved the changes requested, now the project is building too.

image

Thanks,
Nishkalank

@NishkalankBezawada NishkalankBezawada marked this pull request as ready for review October 7, 2024 07:40
@Adam-it
Copy link
Contributor

Adam-it commented Oct 7, 2024

Hey @Adam-it

I have resolved the changes requested, now the project is building too.

Awesome 😍
Thank you for a quick turn around. I will try to review it ASAP 👍

@Adam-it
Copy link
Contributor

Adam-it commented Oct 11, 2024

Hey @Adam-it

I have resolved the changes requested, now the project is building too.

@NishkalankBezawada are you sure you committed all the changes?
Seems like we still have some files where office-ui-fabric-react is used which was removed
image

Copy link
Contributor

@Adam-it Adam-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rechecked locally but I am still unable to build it. Please check my previous comment

@Adam-it Adam-it marked this pull request as draft October 11, 2024 20:50
@hugoabernier
Copy link
Collaborator

I am also unable to build. It does seem that the solution was built with a dev dependency on fast serve, but even after adding it, I wasn't able to serve the web part.

@NishkalankBezawada NishkalankBezawada marked this pull request as ready for review October 13, 2024 17:31
@NishkalankBezawada
Copy link
Contributor Author

Hello @hugoabernier & @Adam-it,

Sorry for the delay, and inconvenience. I have verified and done neccesary changes, now the webpart is building and serving as well :)

image

Thanks,
Nish

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants