fix(sw): return 200-299,304 responses immediately #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Verified that subsequent load is almost instant:
Verified that cache is invalidated for updated github items (description updates):
@whizzzkid @momack2 please review. Preview urls for the urls Molly gave in slack are: |
whizzzkid
approved these changes
Sep 23, 2023
| if (!cachedResponse) { | ||
| return false | ||
| } | ||
| if (!cachedResponse.ok || cachedResponse.status === 304) { |
There was a problem hiding this comment.
Can merge the two if statements.
There was a problem hiding this comment.
Yea, i was just trying to keep them separate and explicit for clarity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #380
This PR updates the caching strategy to prevent the duplicate call to the backend
if we have a cached call, and returns it immediately.
One thing to note, is that vercel-cached responses return HTTP 304 responses,
and
response.okdidn't check for that. This PR also addresses this.So, a call to the backend vercel function, that calls github does NOT happen IFF:
A backend call to the backend vercel function, that calls github, WILL happen IFF:
The cached response's max-age is "too old"